Menu entry corrections CommonMenuBar and MovementDisplay #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+5673
to
+5674
| // Menu entry does not exist | ||
| // clientgui.getMenuBar().setEnabled(MoveCommand.MOVE_TRAITOR.getCmd(), enabled); |
There was a problem hiding this comment.
Why keep these if they don't exist?
There was a problem hiding this comment.
Someone thought at some point they should exist. I personally think all the Move/Fire in-game-action menu commands should be removed. That's what the buttons are for. The menu is for loading games, saving maps or other stuff. In this PR I didn't want to adress any of this, just remove the log errors.
Windchild292
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small corrections to keep the log from being spammed with (justified) error messages (and one actual menu correction).