-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnitReadoutDialog based on AbstractDlg #2910
Conversation
Oh wait - forgot to rename the dialog with its own resource entries!! Grrr. |
Taking a look... other than the above, is there any reason to not just have this dialog wrap around entity view pane? Seems to share the same information but would add the TRO component too. |
Thats the one used in the unit selector, right? I'll look into that. I was just continuing with what the lobby historically did, but good idea that. I wouldnt even bet against there already being such a dialog somewhere... |
It's the one I made that I forgot to replace the unit selector one with... And I'm almost certain the standardized dialog doesn't exist |
OK, update:
It's a bit hacky to set the title of an AbstractDialog to something variable but I don't mind that line. I would have liked to make it scale but since the whole Unit Selector currently doesn't, this would look strange there. |
Ah I forgot: Although the EntityViewPane->AbstractTabbedPane seems to want to save the index of the selected pane, this doesn't seem to work, neither for the unit selector nor for the separate dialog. I don't know why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks great, just one oddity and a missing override
As the title says. No functional change. Separates out the readout dialog from the lobby's "View" menu option into its own class based on AbstractDialog.
I'll say this was effortless.