first crack at bot minefield avoidance #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 4ad1b45 into 588f8b0 - view on LGTM.com new alerts:
|
|
This needs a CI fix, as it is causing a test to NPE |
Windchild292
reviewed
Jun 2, 2021
Comment on lines
+128
to
+131
| if (s == 0) { | ||
| return super.compare(first, second); | ||
| } else { | ||
| return s; |
There was a problem hiding this comment.
Ternary return candidate
|
This pull request introduces 1 alert when merging d4eff68 into 588f8b0 - view on LGTM.com new alerts:
|
Windchild292
approved these changes
Jun 2, 2021
|
|
||
| double hazardAccumulator = 0; | ||
| // hovercraft and WIGEs grinding along the ground detonate minefields on a 12 | ||
| boolean hoverMovement = movingUnit.getMovementMode() == EntityMovementMode.HOVER || |
|
This pull request introduces 1 alert when merging 2397621 into 588f8b0 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at having the bot try to avoid minefields. The basic gist is that the bot will generally prefer not to step on mines if she thinks she will detonate them. The bot client only has access to minefields it knows about.
More detailed breakdown: