Removed some unused variables that were causing IDE warnings.

megamek/src/megamek/client/bot/princess/BehaviorSettings.java

@@ -722,8 +722,6 @@ public boolean isDefault() {
      */
     Element toXml(final Document doc,
                   final boolean includeTargets) {
-        final String METHOD_NAME = "toXml(Document, boolean)";
-
         try {
             final Element behavior = doc.createElement("behavior");
 

megamek/src/megamek/client/ui/swing/CommonMenuBar.java

@@ -73,7 +73,6 @@ public class CommonMenuBar extends JMenuBar implements ActionListener,
     /**
      * When we have a unit list, set this to <code>true</code>.
      */
-    private boolean hasUnitList;
     private JMenuItem fileUnitsReinforce;
     private JMenuItem fileUnitsReinforceRAT;
     private JMenuItem fileRefreshCache;
@@ -1085,7 +1084,7 @@ public synchronized void setBoard(boolean available) {
      *            cleared.
      */
     public synchronized void setUnitList(boolean available) {
-        hasUnitList = available;
+        // manageMenu sets unit menus based on phase not from this setUnitListFlag.
         manageMenu();
     }
 

megamek/src/megamek/client/ui/swing/PointblankShotDisplay.java

@@ -41,7 +41,6 @@
 import megamek.common.Entity;
 import megamek.common.HexTarget;
 import megamek.common.IAimingModes;
-import megamek.common.IBoard;
 import megamek.common.IGame;
 import megamek.common.Mounted;
 import megamek.common.TargetRoll;
@@ -800,7 +799,6 @@ public void target(Targetable t) {
             }
             facing = (facing + weapon.getFacing()) % 6;
             Coords c = ce().getPosition().translated(facing);
-            IBoard board = clientgui.getClient().getGame().getBoard();
             Targetable hexTarget = new HexTarget(c, Targetable.TYPE_HEX_CLEAR);
 
             // Ignore events that will be generated by the select/cursor calls

megamek/src/megamek/client/ui/swing/StatusBarPhaseDisplay.java

@@ -41,7 +41,6 @@
 import megamek.client.ui.swing.widget.MegamekButton;
 import megamek.client.ui.swing.widget.SkinSpecification;
 import megamek.client.ui.swing.widget.SkinXMLHandler;
-import megamek.common.logging.MMLogger;
 import megamek.common.preference.IPreferenceChangeListener;
 import megamek.common.preference.PreferenceChangeEvent;
 
@@ -58,9 +57,6 @@
 public abstract class StatusBarPhaseDisplay extends AbstractPhaseDisplay
         implements ActionListener, MouseListener, KeyListener, IPreferenceChangeListener {
 
-    //L4J Support
-    private MMLogger logger = null;
-
     private static final long serialVersionUID = 639696875125581395L;
 
     protected static final int TRANSPARENT = 0xFFFF00FF;

megamek/src/megamek/client/ui/swing/skinEditor/SkinEditorMainGUI.java

@@ -106,7 +106,6 @@ public class SkinEditorMainGUI extends JPanel implements WindowListener, BoardVi
     public UnitDisplay unitDisplay;
 
     protected JComponent curPanel;
-    private ChatLounge chatlounge;
 
     /**
      * Test entity to display in UnitDisplay.
@@ -566,7 +565,6 @@ private JComponent initializePanel(IGame.Phase phase) {
         switch (phase) {
             case PHASE_LOUNGE:
                 component = new ChatLounge(null);
-                chatlounge = (ChatLounge) component;
                 main = "ChatLounge"; //$NON-NLS-1$
                 component.setName(main);
                 panMain.add(component, main);

megamek/src/megamek/client/ui/swing/tileset/TilesetManager.java

@@ -36,7 +36,6 @@
 import megamek.client.ui.swing.tileset.MechTileset.MechEntry;
 import megamek.client.ui.swing.util.EntityWreckHelper;
 import megamek.client.ui.swing.util.ImageCache;
-import megamek.client.ui.swing.util.PlayerColour;
 import megamek.client.ui.swing.util.RotateFilter;
 import megamek.common.*;
 import megamek.common.annotations.Nullable;
@@ -615,7 +614,6 @@ public synchronized void loadImage(Entity entity, int secondaryPos) {
         Image wreck = wreckTileset.imageFor(entity, secondaryPos);
 
         IPlayer player = entity.getOwner();
-        PlayerColour tint = player.getColour();
 
         Camouflage camouflage = entity.getCamouflageOrElse(player.getCamouflage());
         EntityImage entityImage = null;

megamek/src/megamek/common/MULParser.java

@@ -1759,7 +1759,6 @@ else if (!mounted.getType().getInternalName()
                     }
                 }
                 if (entity.isSupportVehicle() && (mounted.getType() instanceof InfantryWeapon)) {
-                    int clipSize = ((InfantryWeapon) mounted.getType()).getShots();
                     for (Mounted ammo = mounted.getLinked(); ammo != null; ammo = ammo.getLinked()) {
                         if (((AmmoType) ammo.getType()).getMunitionType() == AmmoType.M_INFERNO) {
                             if (!inferno.isEmpty()) {

megamek/src/megamek/common/SmallCraft.java

@@ -42,7 +42,6 @@ public class SmallCraft extends Aero {
     // Maps transported crew,passengers,marines to a host ship so we can match them up again post-game
     private Map<String,Integer> nOtherCrew = new HashMap<>();
     private Map<String,Integer> passengers = new HashMap<>();
-    private Map<Integer,Integer> nOtherMarines = new HashMap<>();
 
     // escape pods and lifeboats
     private int escapePods = 0;

megamek/src/megamek/common/Warship.java

@@ -219,7 +219,6 @@ public double getCost(boolean ignoreAmmo) {
         double[] driveCost = new double[6];
         int driveIdx = 0;
         double driveCosts = 0;
-        int dockingCollars = 0;
         // Drive Coil
         driveCost[driveIdx++] += 60000000.0 + (75000000.0 * getDocks(true));
         // Initiator

megamek/src/megamek/common/loaders/MtfFile.java

@@ -858,7 +858,7 @@ private void parseNoCritEquipment(Mech mech, String name) throws EntityLoadingEx
         EquipmentType eq = EquipmentType.get(name);
         if (eq != null) {
             try {
-                Mounted mount = mech.addEquipment(eq, loc);
+                mech.addEquipment(eq, loc);
             } catch (LocationFullException ex) {
                 throw new EntityLoadingException(ex.getMessage());
             }

megamek/src/megamek/common/verifier/TestProtomech.java

@@ -341,8 +341,6 @@ public String printWeightControls() {
     public StringBuffer printMiscEquip(StringBuffer buff, int posLoc,
             int posWeight) {
         for (Mounted m : getEntity().getMisc()) {
-            MiscType mt = (MiscType) m.getType();
-
             buff.append(StringUtil.makeLength(m.getName(), 20));
             buff.append(
                     StringUtil.makeLength(getLocationAbbr(m.getLocation()),
@@ -356,8 +354,6 @@ public StringBuffer printMiscEquip(StringBuffer buff, int posLoc,
     @Override
     public StringBuffer printWeapon(StringBuffer buff, int posLoc, int posWeight) {
         for (Mounted m : getEntity().getWeaponList()) {
-            WeaponType mt = (WeaponType) m.getType();
-
             buff.append(StringUtil.makeLength(m.getName(), 20));
             buff.append(
                     StringUtil.makeLength(getLocationAbbr(m.getLocation()),

megamek/src/megamek/server/Server.java

@@ -18435,7 +18435,6 @@ private void resolveChargeDamage(Entity ae, Entity te, ToHitData toHit, int dire
         }
 
         // track any additional damage to the attacker due to the target having spikes
-        int spikeDamage = 0;
         while (damage > 0) {
             int cluster = Math.min(5, damage);
             // Airmech ramming attacks do all damage to a single location
@@ -27949,7 +27948,6 @@ public Vector<Report> explodeEquipment(Entity en, int loc, Mounted mounted) {
      * Possible to override 'is explosive' check
      */
     public Vector<Report> explodeEquipment(Entity en, int loc, Mounted mounted, boolean overrideExplosiveCheck) {
-        final String METHOD_NAME = "explodeEquipment(Entity,int,Mounted)";
         Vector<Report> vDesc = new Vector<>();
         // is this already destroyed?
         if (mounted.isDestroyed()) {

megamek/unittests/megamek/client/bot/princess/NewtonAerospacePathRankerTest.java

@@ -13,14 +13,15 @@
  */
 package megamek.client.bot.princess;
 
-import megamek.common.IGame;
-import megamek.common.options.GameOptions;
-
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
+import megamek.common.IGame;
+import megamek.common.options.GameOptions;
+
 /**
  * @author Deric "Netzilla" Page (deric dot page at usa dot net)
  * @version $Id$
@@ -29,11 +30,15 @@
 @RunWith(JUnit4.class)
 public class NewtonAerospacePathRankerTest {
 
+    @SuppressWarnings("unused")
     private Princess mockPrincess;
+    @SuppressWarnings("unused")
     private NewtonianAerospacePathRanker mockPathRanker;
+    @SuppressWarnings("unused")
     private IGame mockGame;
+    @SuppressWarnings("unused")
     private GameOptions mockGameOptions;
-
+ 
     @Before
     public void setUp() {
         /*mockPathRanker = Mockito.mock(NewtonianAerospacePathRanker.class);
@@ -56,6 +61,7 @@ public void setUp() {
         Mockito.when(mockGameOptions.booleanOption(OptionsConstants.ADVAERORULES_STRATOPS_SENSOR_SHADOW)).thenReturn(true);*/
     }
 
+    @Ignore
     @Test
     public void testCalculateSensorShadowMod() {
         /*final MovePath mockPath = Mockito.mock(MovePath.class);