Scenario Additions (Planetary Cond. / Dialog skip)

[SJuliez]

• Adds complete planetary conditions settings to .mms scenarios
• Allows settings planetary conditions as fixed, skipping the respective dialog when the scenario starts
• Also allows setting the game options as fixed, skipping that dialog
• Also allows setting player assignment as fixed ("SinglePlayer"), skipping the player assignment/camo dialog and the host game dialog. In this case the first player of the scenario is the local player and the others are connected as Princess. When all is fixed, the game proceeds directly from scenario selection to in-game deployment/first round.
• Updated the example.mms with the new settings and missing settings (camo examples)

Resolves #2133

[Windchild292]

Few things first

[Windchild292]

Can we separate these if statements so that there is a whitespace between the close } and the next if statement?

[Windchild292]

Also, if we are just going to use a setter immediately after can we just use the same line and combine them. Not much point to separate them out.

[SJuliez]

a) You mean an empty line after }? parsePlanetaryConditions is so uninteresting that I wanted it to be short. No complexity here.
b) What? You mean like g.getPlanetaryConditions().setTemperature(Integer.parseInt(p.getString(PARAM_PLANETCOND_TEMP)));?
I can do that but it makes lines very long and Id rather have them like this than with a break in the middle.

[SJuliez]

Arlith used to run a code formatter that would cut the lines very short iirc and (I think) sometimes result in awful line breaks. I'd rather break manually. But if no one does this, I can sure use long code lines.

[Windchild292]

Exactly like this. The extra space is an accessibility bit that assists in separating out the statements to a reader. Otherwise, it can come off as being a single giant chained if statement even though it is not the case