Left Clicking a Unit no longer targets the unit by default.

[sldfgunslinger2766]

Environment

v.0.49.0 Dev
Java vendor AdoptOpenJDK
Java version 11.0.10
Platform Windows 10 10.0 (amd64)
Total memory available to MegaMek: 1,048,576 kB

Description

In past MM versions, left clicking a unit during the targeting phase would target the unit by default, enabling the 'Fire' tab. In this latest Dev version, a player must now right click the unit which then deployes the target/select drop down.

Files

megameklog.txt

[sldfgunslinger2766]

This behavior also seems to reset torso twisting, but I need to test this further.

[Tecmes]

Indeed left-click twists the torso, and right-click targets. But it doesn't seem intentional as right-clicking ALSO bring the contextual menu.

Click-twisting would be great, though. Why not shift-clicking? Just sayin'

[SJuliez]

I can't reproduce this. Shift-clicking twists the torso and left-clicking on some unit targets it. I know of no changes in that area (which of course doesn't mean there can't be some bug).

[sldfgunslinger2766]

I can't reproduce this. Shift-clicking twists the torso and left-clicking on some unit targets it. I know of no changes in that area (which of course doesn't mean there can't be some bug).

Right on, maybe I'm just missing something with the torso twist. I've always used the tab at the bottom to choose a twist facing That said, the default left click to target a unit is the main issue.

[HammerGS]

Out of curiosity, did anyone having the issue copy their mmconfig folder over to the new version?

[sldfgunslinger2766]

I do tend to copy over a couple of files in mmconf from version to version. But, the log I posted above is from a fresh download of the 49 dev from the website.

[Tecmes]

Fresh install for me, but I did load a MM prefs from a version saved from 0.48.

[HoneySkull]

Could Pull Request #2809 have impacted this? I haven't been able to connect it, but it's plausible.

[HoneySkull]

I've confirmed this is caused by #2809. You can see in version 0.48 stable when you left click a target (or other hex) and you hold down the mouse button, a light blue hex boarder appears, and then when you let go of the left mouse button (button up) the unit/hex becomes targeted with a dark blue hex.

After #2809 was merged, when you left mouse button click, it's like it's only registering the left mouse down but NOT the left mouse up event. This makes sense since I replaced the deprecated BUTTON1_MASK with BUTTON1_DOWN_MASK as per the JDK11 Swing suggestion. I'm guessing there is some difference in processing the extended modifiers from the new getModifiersEx() over the deprecated getModifiers().

[NickAragua]

Let's let that be a lesson to us all to be wary of willy-nilly replacing deprecated code without testing what it affects.

[HoneySkull]

Guilty as charged! Should I roll back the KeyEvent upgrade (#2809) from master and continue to work on the testing/fixing in private or leave it in master and continue to test/fix. I see @NickAragua has offered a fix - Thank you!

[Windchild292]

Leave it, Nick's got a fix open for the issue and the overall swapover is an improvement