Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle Numbering #2597

Open
BairdEC opened this issue Jan 23, 2021 · 6 comments
Open

Vehicle Numbering #2597

BairdEC opened this issue Jan 23, 2021 · 6 comments
Labels
Bug MHQ-origin MM Issues Issues in MegaMek that originate from MekHQ. Needs Investigation This issue needs investigation and/or triage. Outdated Test against current Milestone or the latest Nightly Build

Comments

@BairdEC
Copy link

BairdEC commented Jan 23, 2021

Environment

0.47.16 - MM started from MHq
Java build 1.8.0_271-b09
Win10

Description

MM imported three standard Manticore tanks from MHq, but numbered them 1, 1, and 2.

Numbering

Files

War Wolves30470519.cpnx.gz
customs.zip
@Windchild292 Windchild292 added Bug Needs Investigation This issue needs investigation and/or triage. labels Jan 28, 2021
@SuperStucco
Copy link
Collaborator

I've encountered the same thing with different tanks. If you look at the screen grab, there's also multiple 'Vedette Medium Tank' without any numeric qualifiers.

I tried removing the extra tanks in the MM lobby and manually adding a replacement, each time they came in without the numeric qualifiers.

@sixlettervariables
Copy link
Contributor

Are there any logs? This is clearly a race condition in the unit naming logic on the MM side.

@BairdEC
Copy link
Author

BairdEC commented Jan 30, 2021

Here you go. I didn't grab the logs the first time around, but the game did the same thing when I reloaded the save file.

mekhqlog.txt
megameklog.txt

@sixlettervariables
Copy link
Contributor

The logs don't show anything funny, but the code clearly can race between the accesses to the hash table. I'm working on a fix.

sixlettervariables added a commit to sixlettervariables/megamek that referenced this issue Feb 27, 2021
@sixlettervariables
Switch to a re-usable class to be shared with MHQ MegaMek#2597
1216e4c
@sixlettervariables
Copy link
Contributor

This is actually an MHQ bug, interestingly enough.

@BullseyeSmith
Copy link

MegaMek/mekhq#2412

sixlettervariables added a commit that referenced this issue Mar 17, 2021
@sixlettervariables
Merge pull request #2632 from sixlettervariables/issue-2597-protect-d…
7c57ed4 
…uplicate-name-hash

Issue #2597: Add thread safety to duplicate name hash
sixlettervariables added a commit to MegaMek/mekhq that referenced this issue Mar 17, 2021
@sixlettervariables
Merge pull request #2445 from sixlettervariables/issue-2597-protect-d…
00db4b9 
…uplicate-name-hash

Issue MegaMek/megamek#2597: Use MM's new UnitNameTracker for name collisions
@repligator repligator added the MHQ-origin MM Issues Issues in MegaMek that originate from MekHQ. label Jul 16, 2024
@HammerGS HammerGS added the Outdated Test against current Milestone or the latest Nightly Build label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug MHQ-origin MM Issues Issues in MegaMek that originate from MekHQ. Needs Investigation This issue needs investigation and/or triage. Outdated Test against current Milestone or the latest Nightly Build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sixlettervariables @HammerGS @BairdEC @Windchild292 @BullseyeSmith @SuperStucco @repligator