Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MSVC checks from AppVeyor to GitHub Actions #2194

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

cjee21
Copy link
Contributor

@cjee21 cjee21 commented Feb 12, 2025

No description provided.

@JeromeMartinez
Copy link
Member

JeromeMartinez commented Feb 12, 2025

@cjee21 I just removed the Appveyor hook in the project settings, please force push with a slight modification e.g. last commit date for forcing the CI to run again.

@JeromeMartinez
Copy link
Member

"warnaserror" is good but a bit early :-p, I am working right now on removing the warnings.

@JeromeMartinez
Copy link
Member

@cjee21 please rebase.

@JeromeMartinez JeromeMartinez merged commit 7c5ad4f into MediaArea:master Feb 12, 2025
11 checks passed
@JeromeMartinez
Copy link
Member

With #2196 we'll be with all on GitHub and all warnings from all compilers caught.

@cjee21
Copy link
Contributor Author

cjee21 commented Feb 12, 2025

all warnings from all compilers caught.

But take note that MSVC MediaInfoLib is still on level 1 warnings. The other projects are at level 3 or 4. Last I checked, even increasing to level 2 produces a number of warnings.

@cjee21 cjee21 deleted the CI branch February 12, 2025 19:16
@JeromeMartinez
Copy link
Member

Last I checked, even increasing to level 2 produces a number of warnings.

True, but remaining issues with level 2 after my pass today are only possible loss of data due to conversions, I'll manage that... but not this week.
GCC and LLVM use the default warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants