Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searchindexurl handling for BaseURLs with folders #941

Closed

Conversation

christophcemper
Copy link

@christophcemper christophcemper commented Oct 22, 2024

Related to #940

Update search.html to handle BaseURLs with folders correctly and remove artificial language code prefixing.

  • Remove .Site.LanguagePrefix from the $url variable construction.
  • Change relLangURL to relURL for window.index_js_url.

For more details, open the Copilot Workspace session.

Related to McShelby#940

Update `search.html` to handle BaseURLs with folders correctly and remove artificial language code prefixing.

* Remove `.Site.LanguagePrefix` from the `$url` variable construction.
* Change `relLangURL` to `relURL` for `window.index_js_url`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/McShelby/hugo-theme-relearn/issues/940?shareId=XXXX-XXXX-XXXX-XXXX).
@McShelby McShelby added the wontchange This will not be worked on label Oct 24, 2024
@McShelby
Copy link
Owner

A working bug fix for all permutations needs to be different

@McShelby McShelby closed this Oct 24, 2024
@McShelby McShelby added invalid This doesn't seem right and removed wontchange This will not be worked on labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants