-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSA ALT test guards #6950
Merged
daverodgman
merged 3 commits into
Mbed-TLS:development
from
daverodgman:fix-rsaalt-test-guards
Jan 20, 2023
Merged
Fix RSA ALT test guards #6950
daverodgman
merged 3 commits into
Mbed-TLS:development
from
daverodgman:fix-rsaalt-test-guards
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
3 tasks
daverodgman
added
bug
needs-review
Every commit must be reviewed by at least two team members,
needs-backports
Backports are missing or are pending review and approval.
needs-ci
Needs to pass CI tests
needs-reviewer
This PR needs someone to pick it up for review
size-s
Estimated task size: small (~2d)
single-reviewer
This PR qualifies for having only one reviewer
component-test
Test framework and CI scripts
priority-medium
Medium priority - this can be reviewed as time permits
labels
Jan 20, 2023
Presumably there isn't anything in the CI to catch this combination of defines - should we add something to avoid a regression in future? |
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
I've added a regression test (compile-only to avoid bloating CI time). |
Compile-only is fine |
tom-cosgrove-arm
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tom-cosgrove-arm
added
approved
Design and code approved - may be waiting for CI or backports
and removed
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
labels
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Design and code approved - may be waiting for CI or backports
bug
component-test
Test framework and CI scripts
needs-backports
Backports are missing or are pending review and approval.
needs-ci
Needs to pass CI tests
priority-medium
Medium priority - this can be reviewed as time permits
single-reviewer
This PR qualifies for having only one reviewer
size-s
Estimated task size: small (~2d)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3174.
Gatekeeper checklist