Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSA ALT test guards #6950

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Fix RSA ALT test guards #6950

merged 3 commits into from
Jan 20, 2023

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Jan 20, 2023 •
edited
Loading

Description

Fixes #3174.

Gatekeeper checklist

@daverodgman
Fix test guards
dc3b154 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Add Changelog
fd09b31 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman mentioned this pull request Jan 20, 2023
Merged
3 tasks
@daverodgman daverodgman added bug needs-review Every commit must be reviewed by at least two team members, needs-backports Backports are missing or are pending review and approval. needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer component-test Test framework and CI scripts priority-medium Medium priority - this can be reviewed as time permits labels Jan 20, 2023
@daverodgman daverodgman changed the title Fix rsaalt test guards Fix RSA ALT test guards Jan 20, 2023
@tom-cosgrove-arm
Copy link
Contributor

Presumably there isn't anything in the CI to catch this combination of defines - should we add something to avoid a regression in future?

@daverodgman
Add regression test
1a034dc 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Copy link
Contributor Author

I've added a regression test (compile-only to avoid bloating CI time).

@tom-cosgrove-arm
Copy link
Contributor

Compile-only is fine

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 20, 2023
@daverodgman daverodgman merged commit d4fa9e9 into Mbed-TLS:development Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-test Test framework and CI scripts needs-backports Backports are missing or are pending review and approval. needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failure if compiled without MBEDTLS_PK_RSA_ALT_SUPPORT
2 participants
@daverodgman @tom-cosgrove-arm