mbedtls_mpi_sub_abs: Skip memcpy when redundant (#6701). #6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some contexts, the output pointer may equal the first input pointer, in which case copying is not only superfluous but results in "Source and destination overlap in memcpy" errors from Valgrind (as I observed in the context of ecp_double_jac) and a diagnostic message from TrustInSoft Analyzer (as Pascal Cuoq reported in the context of other ECP functions called by cert-app with a suitable certificate). Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
3 tasks
|
That's fair, though I'll go with the US spelling of "behavior", for which I do see precedent. ;-)
|
tom-cosgrove-arm
added
needs-review
daverodgman
added
approved
gilles-peskine-arm
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Looks good to me, but please rewrite the commit messages to ensure that all commits have a signoff line.
gilles-peskine-arm
added
needs-work
and removed
approved
Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
|
AFAICT, only the ChangeLog simplification lacked such a line; fixed. Thanks, and sorry for the accidental omission.
|
|
Thanks for fixing that; can you prepare the backport now? We normally merge a PR and its backport at the same time, so we need both before this can be merged. |
tom-cosgrove-arm
added
approved
tom-cosgrove-arm
approved these changes
Jan 31, 2023
|
Sounds good, thanks! I've pushed a squashed backport: https://github.com/ucko/mbedtls/tree/2023a-bignum-2.28
|
3 tasks
|
So I see, thanks. Opened #7001.
|
This was referenced Feb 10, 2023
gouriano
pushed a commit
to ncbi/ncbi-cxx-toolkit-public
that referenced
this pull request
Jul 12, 2023
It still lacks Mbed-TLS/mbedtls#6942 but now formally calls __GI_memcpy rather than memcpy@@GLIBC_2.14. JIRA: CXX-13141. git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@100239 78c7ea69-d796-4a43-9a09-de51944f1b03
gouriano
pushed a commit
to ncbi/ncbi-cxx-toolkit-public
that referenced
this pull request
Jul 27, 2023
It still lacks Mbed-TLS/mbedtls#6942 but now formally calls __GI_memcpy rather than memcpy@@GLIBC_2.14. JIRA: CXX-13141. git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@100239 78c7ea69-d796-4a43-9a09-de51944f1b03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some contexts, the output pointer may equal the first input pointer, in which case copying is not only superfluous but results in "Source and destination overlap in memcpy" errors from Valgrind (as I observed in the context of ecp_double_jac) and a diagnostic message from TrustInSoft Analyzer (as Pascal Cuoq reported in the context of other ECP functions called by cert-app with a suitable certificate).
I will be happy to supply a corresponding LTS PR in due course, particularly given that I'm using that branch myself.
(Split from #6930.)
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.