Add Gamma ramp; properly cumulate temp, brightness, gamma, inversion #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it works for me too. The code looks good. Not related to your PR (and probably |
Inversion now flips the cumulated gamma ramp left-to-right (rather than upside-donw), keeping any temperature, brightness and gamma adjustments. The script toggle-invert-display.sh inverts the display colors and adjusts gamma in the inverted mode to compensate for perceptual nonlinearity.
These are from some extension font (maybe font-awesome, not sure). I can see them in my terminal but not "🌙" or "💡" (which are form unicode) (I guess I have to install something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works flawlessly for me, but check carefully - this is my first hackery in Rust, and I don't know Rust.
You probably want to squash the commits (sorry) on merging.
As an aside, I noticed that the symbols in the Waybar example (where Gamma uses γ) use Unicode code points from a private use area and are thus unlikely to be displayed properly for many users (including me).