Add Paragraph Delimited Mappings Extended #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoPangxie732
requested changes
Oct 24, 2024
modules/mapping-api/src/main/java/cn/maxpixel/mcdecompiler/mapping/format/MappingFormats.java
Outdated
Show resolved
Hide resolved
.../mapping-api/src/main/java/cn/maxpixel/mcdecompiler/mapping/processor/MappingProcessors.java
Outdated
Show resolved
Hide resolved
...t-detector/src/main/java/cn/maxpixel/mcdecompiler/mapping/detector/DefaultDetectionUnit.java
Outdated
Show resolved
Hide resolved
...t-detector/src/main/java/cn/maxpixel/mcdecompiler/mapping/detector/DefaultDetectionUnit.java
Outdated
Show resolved
Hide resolved
.../mapping-api/src/main/java/cn/maxpixel/mcdecompiler/mapping/generator/MappingGenerators.java
Outdated
Show resolved
Hide resolved
|
The processor and the generator part are big, so I will review them on the weekend |
|
by the way, I'm curious about how you type |
XiaoPangxie732
approved these changes
Oct 28, 2024
XiaoPangxie732
force-pushed
the
master
branch
from
9ef7ce4 to
9c793b0
Compare
|
wait what |
|
1 |
Full class name by default
XiaoPangxie732
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the format Paragraph Delimited Mappings Extended https://pagure.io/FeatureCreep/MappingExFormat with the exception of the Include(inheritance structure) and AccessFlag parts which do not have equivalents in other mapping formats.