-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from apple:master #25
Commits on Jun 15, 2020
-
[TypeChecker] Add a entry point to be used for code completion
As part of the code completion redesign this new entry point is going to replace use of: - `typeCheckExpression` - `getTypeOfExpressionWithoutApplying` (which could be removed) and possibly other methods currently used to retrieve information for code completion purposes. Advantages of a new approach: - Avoids mutating AST; - Allows to avoid sub-expression type-checking; - Allows code completion access to multiple solutions in ambiguous cases; - Provides all possible solutions - valid and invalid (with holes); - Allows code completion to easily access not only types but overload choices and other supplimentary information associated with each solution.
Configuration menu - View commit details
-
Copy full SHA for ccd7167 - Browse repository at this point
Copy the full SHA ccd7167View commit details -
[Darwin test config] Use the SDK when running swift/swiftc in tests.
The Swift driver (swift/swiftc) is supposed to always be used with an accompanying SDK, which it derives from the environment. Our test infrastructure was clearing out this SDK, making it deviate from the normal operating environment unnecessarily. Switch to providing the SDK used for building the standard library, which provides a more-consistent test environment, and tag the few places in tests where we have explicit dependencies on "no SDK."
Configuration menu - View commit details
-
Copy full SHA for 1be17a2 - Browse repository at this point
Copy the full SHA 1be17a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1e8a35 - Browse repository at this point
Copy the full SHA a1e8a35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ee3342 - Browse repository at this point
Copy the full SHA 1ee3342View commit details -
IRGen: Use the right descriminator for AutoDiffDerivativeFunctions
Fixes the failure in AutoDiff/validation-test/forward_mode.swift on arm64e. rdar://64192250
Configuration menu - View commit details
-
Copy full SHA for abf65bb - Browse repository at this point
Copy the full SHA abf65bbView commit details
Commits on Jun 16, 2020
-
[arc] Change guaranteed arc opts to be based on SemanticARCOpts and m…
…ove from Diagnostic pipeline -> Onone pipeline. The pass is already not being run during normal compilation scenarios today since it bails on OSSA except in certain bit-rot situations where a test wasn't updated and so was inadvertently invoking the pass. I discovered these while originally just trying to eliminate the pass from the diagnostic pipeline. The reason why I am doing this in one larger change is that I found there were a bunch of sil tests inadvertently relying on guaranteed arc opts to eliminate copy traffic. So, if I just removed this and did this in two steps, I would basically be unoptimizing then re-optimizing the tests. Some notes: 1. The new guaranteed arc opts is based off of SemanticARCOpts and runs only on ossa. Specifically, in this new pass, we just perform simple canonicalizations that do not involve any significant analysis. Some examples: a copy_value all of whose uses are destroys. This will do what the original pass did and more without more compile time. I did a conservative first approximation, but we can probably tune this a bit. 2. the reason why I am doing this now is that I was trying to eliminate the enable-ownership-stripping-after-serialization flag and discovered that the test opaque_value_mandatory implicitly depends on this since sil-opt by default was the only place left in the compiler with that option set to false by default. So I am eliminating that dependency before I land the larger change.
Configuration menu - View commit details
-
Copy full SHA for 702c1bc - Browse repository at this point
Copy the full SHA 702c1bcView commit details -
Remove Type's hash_value function
Defining `hash_value` for `Type` makes it easy to forget that the underlying pointer is being hashed directly without canonicalization. Instead, define it only for `CanType`, and make `Type` users spell `getPointer` explicitly.
Configuration menu - View commit details
-
Copy full SHA for ff61b24 - Browse repository at this point
Copy the full SHA ff61b24View commit details -
Fix equality of TypeWitnessAndDecl
It was incorrectly hashing the type as a pointer but canonicalizing for equality. Change equality to compare pointers.
Configuration menu - View commit details
-
Copy full SHA for 6041d2a - Browse repository at this point
Copy the full SHA 6041d2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f89a385 - Browse repository at this point
Copy the full SHA f89a385View commit details -
[Reflection] NFC: Workaround LLVM C++ standard library weirdness
Pull request #32244 introduced the use of `std::stringstream` but that causes vtables to be generated and we don't want that.
Configuration menu - View commit details
-
Copy full SHA for bf8f50f - Browse repository at this point
Copy the full SHA bf8f50fView commit details -
Merge pull request #32357 from DougGregor/test-with-sdk-on-darwin
[Darwin test config] Use the SDK when running swift/swiftc in tests.
Configuration menu - View commit details
-
Copy full SHA for 77e0ad1 - Browse repository at this point
Copy the full SHA 77e0ad1View commit details -
Merge pull request #32406 from davezarzycki/pr32406
[Reflection] NFC: Workaround LLVM C++ standard library weirdness
Configuration menu - View commit details
-
Copy full SHA for 9617cfe - Browse repository at this point
Copy the full SHA 9617cfeView commit details -
Merge pull request #32396 from aschwaighofer/irgen_fix_discriminator_…
…auto_diff_deriv IRGen: Use the right descriminator for AutoDiffDerivativeFunctions
Configuration menu - View commit details
-
Copy full SHA for ecaf9af - Browse repository at this point
Copy the full SHA ecaf9afView commit details -
Merge pull request #32399 from hamishknight/salted-hash
Remove Type's hash_value function
Configuration menu - View commit details
-
Copy full SHA for 0de7fb8 - Browse repository at this point
Copy the full SHA 0de7fb8View commit details -
Merge pull request #32390 from gottesmm/pr-c38328b82781ec804d14966507…
…bcc7995465d3bf [arc] Change guaranteed arc opts to be based on SemanticARCOpts and move from Diagnostic pipeline -> Onone pipeline.
Configuration menu - View commit details
-
Copy full SHA for fe39c72 - Browse repository at this point
Copy the full SHA fe39c72View commit details -
Merge pull request #32401 from akyrtzi/fix-clang-include-inherited-co…
…nvenience-inits-for-members [ClangImporter] Follow-up for #32214, fix assertion hit due to missing check
Configuration menu - View commit details
-
Copy full SHA for cc5335c - Browse repository at this point
Copy the full SHA cc5335cView commit details -
Merge pull request #32391 from xedin/type-check-for-code-completion
[TypeChecker] Add a entry point to be used for code completion
Configuration menu - View commit details
-
Copy full SHA for f159175 - Browse repository at this point
Copy the full SHA f159175View commit details