Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the polyfill performs a brand check using the global
AbortSignal.prototype.aborted
(source). This makes it difficult to use the polyfill in a non-DOM environment where there is no globalAbortSignal
, and whereAbortController
andAbortSignal
themselves need to be polyfilled.This PR loosens the check, allowing any object with a boolean
aborted
property to be accepted as a validAbortSignal
. This is a small deviation from the specification, but makes the polyfill usable in more environments (e.g. Node).In the future, if the polyfill is able to use the native streams implementation (#20), we must ensure that any polyfilled
AbortSignal
is first converted to a nativeAbortSignal
before calling the nativepipeTo
/pipeThrough
implementation.