Provide a setup command taking care of enaml files #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuDartiailh
changed the title
|
This is good to go from my end. @tillbey you expressed some interest in this idea would you mind reviewing the patch ? |
|
As this means that enaml, need to be installed before calling the custom setup if the package use it, it may make sense to document how to go round this issue by using setup_requires and defining custom commands delaying the imports. |
MatthieuDartiailh
force-pushed
the
enaml_setup
branch
from
70397c1 to
9a45e45
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have enaml files automatically included and byte-compiled by setuptools.