fix: Allow ampersands in templated URLs for module provider, allowing…

… query string delimiter to not be escaped Issue #546
MatthewJohn · Oct 22, 2024 · c688aa2 · c688aa2
1 parent 9705639
commit c688aa2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/terrareg/models.py b/terrareg/models.py
@@ -2810,7 +2810,7 @@ def update_repo_clone_url_template(self, repo_clone_url_template):
                 # TypeError is thrown when port is None when trying to convert to an int
                 pass
 
-            repo_clone_url_template = urllib.parse.quote(repo_clone_url_template, safe=r'\{\}/:@%?=')
+            repo_clone_url_template = urllib.parse.quote(repo_clone_url_template, safe=r'\{\}/:@%?=&')
 
         original_value = self._get_db_row()['repo_clone_url_template']
         if original_value != repo_clone_url_template:
@@ -2878,7 +2878,7 @@ def update_repo_browse_url_template(self, repo_browse_url_template):
                 # TypeError is thrown when port is None when trying to convert to an int
                 pass
 
-            repo_browse_url_template = urllib.parse.quote(repo_browse_url_template, safe=r'\{\}/:@%?=')
+            repo_browse_url_template = urllib.parse.quote(repo_browse_url_template, safe=r'\{\}/:@%?=&')
 
         original_value = self._get_db_row()['repo_browse_url_template']
         if original_value != repo_browse_url_template:
@@ -2939,7 +2939,7 @@ def update_repo_base_url_template(self, repo_base_url_template):
                 # TypeError is thrown when port is None when trying to convert to an int
                 pass
 
-            repo_base_url_template = urllib.parse.quote(repo_base_url_template, safe=r'\{\}/:@%?=')
+            repo_base_url_template = urllib.parse.quote(repo_base_url_template, safe=r'\{\}/:@%?=&')
 
         original_value = self._get_db_row()['repo_base_url_template']
         if original_value != repo_base_url_template: