Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease bundle size + update readme #54

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Decrease bundle size + update readme #54

merged 14 commits into from
Sep 18, 2024

Conversation

MattCCC
Copy link
Owner

@MattCCC MattCCC commented Sep 17, 2024

Features:

  • Add custom fetcher typings
  • Detect Response from custom fetchers and append additional info to responses if possible

Improvements:

  • Decrease bundle size by up to 5%
  • Improve ResponseError typings

Fixes:

  • Properly bind response instance to fetch responses
  • Improve config checks and prioritization of per-request settings
  • onError interceptor should work also for cancelled requests
  • Config for the custom fetcher should be treated the same way as for native fetch()

Docs:

  • Update readme with latest values in the Plugin Comparison Table
  • Update readme Settings table

Copy link

github-actions bot commented Sep 17, 2024

size-limit report 📦

Path Size
dist/browser/index.mjs 2.84 KB (-1.5% 🔽)
dist/browser/index.global.js 2.99 KB (-1.2% 🔽)

Copy link
Collaborator

@red-game-dev red-game-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MattCCC MattCCC merged commit e8ed7aa into master Sep 18, 2024
9 checks passed
@MattCCC MattCCC deleted the decrease-bundle-size branch September 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants