Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Queue Manager with Request Deduplication #52

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Introduce Queue Manager with Request Deduplication #52

merged 3 commits into from
Sep 12, 2024

Conversation

MattCCC
Copy link
Owner

@MattCCC MattCCC commented Sep 12, 2024 •
edited
Loading

Features:

  • Added "dedupeTime" setting to control request deduplication (1 second by default) - requests with same configuration are treated as one request if fired within particular interval
  • Requests Queue can now properly handle high concurrency environments thanks to better locking

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/browser/index.mjs 2.78 KB (+1.9% 🔺)
dist/browser/index.global.js 0 B (+100% 🔺)

red-game-dev
red-game-dev approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@red-game-dev red-game-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, LGTM 🚀

@MattCCC
Copy link
Owner Author

MattCCC commented Sep 12, 2024

Caching will be handled separately. Let's leave the deduplication only here

@MattCCC MattCCC merged commit 8257282 into master Sep 12, 2024
9 checks passed
@MattCCC MattCCC deleted the introduce-caching branch September 12, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-game-dev red-game-dev red-game-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattCCC @red-game-dev