Skip to content

Commit

Permalink
Removing connection establishment before adding node to NodeGraph
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuakarp committed Feb 3, 2022
1 parent 080c57e commit 6cfc976
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions src/nodes/NodeConnectionManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -504,17 +504,6 @@ class NodeConnectionManager {
continue;
}
if (nodeData.id.equals(targetNodeId)) {
// FoundTarget = true;
// Attempt to create a connection to the node. Will throw an error
// (ErrorConnectionStart, from ConnectionForward) if the connection
// cannot be established

// TODO: For now, will simply add this target node without creating a
// connection to it
// await this.nodeManager.createConnectionToNode(
// nodeData.id,
// nodeData.address,
// );
await this.nodeGraph.setNode(nodeData.id, nodeData.address);
foundAddress = nodeData.address;
// We have found the target node, so we can stop trying to look for it
Expand Down Expand Up @@ -607,16 +596,6 @@ class NodeConnectionManager {
);
for (const n of nodes) {
await this.nodeGraph.setNode(n.id, n.address);
// TODO: This connection step seems unnecessary, consider removing it
// try {
// await this.createConnection(n.id);
// } catch (e) {
// if (e instanceof nodesErrors.ErrorNodeConnectionTimeout) {
// continue;
// } else {
// throw e;
// }
// }
}
}
} finally {
Expand Down

0 comments on commit 6cfc976

Please sign in to comment.