Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP Milestone #55

Merged
merged 62 commits into from
Nov 4, 2020
Merged

MVP Milestone #55

merged 62 commits into from
Nov 4, 2020

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented Oct 26, 2020

Changes:

  1. using vue3 and vuex4
  2. using electron-builder and webpack-cli for building

Fixes #53
Fixes #54

@robert-cronin robert-cronin added the development Standard development label Oct 26, 2020
@robert-cronin robert-cronin added this to the PolyKey MVP milestone Oct 26, 2020
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Oct 26, 2020

This migration is only migrating the vue components.

But later by bringing in some other changes, this will also make the application build for NixOS and other platforms.

@CMCDragonkai
Copy link
Member

This needs to pull in changes from cva_test and temp_mvp.

@robert-cronin
Copy link
Contributor Author

cva_test brings in specific changes from vue3 and temp_mvp is more for the nixos builder specific stuff

@CMCDragonkai
Copy link
Member

Aiming for this PR to be merged by the end of this week.

@CMCDragonkai
Copy link
Member

Current status:

  1. Can build on Mac - but the build doesn't have any components
  2. Cannot build on NixOS
  3. Need to successful build for NixOS plus components that are migrated

@CMCDragonkai
Copy link
Member

@gideonairex if this PR can be merged within this week with working builds and ported-over components, then we can start working on drafting the UI.

Please start writing comments here too instead of inside the issues. The issues are for general discussion about the task. Once the task is started, write comments into the PR instead.

@gideonairex
Copy link
Contributor

Current Status:

  1. Build is working in NixOS

@CMCDragonkai
Copy link
Member

Are we merging this?

@CMCDragonkai
Copy link
Member

I'm not able to answer the question about useStore vs useModule. Can you explain further? In the interests of time, make your best judgement and proceed. @gideonairex

@robert-cronin
Copy link
Contributor Author

I think we can merge this on Monday, there were some issues with nix not being able download some npm packages, but I suspect that was just an issue with my connection. Once we resolve that issue and polykey is installable on our machines then we can go ahead and merge I think 👍

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Nov 1, 2020 via email

@robert-cronin
Copy link
Contributor Author

robert-cronin commented Nov 2, 2020

The build is working now, but there are a few issues after installation has finished, namely:

  1. polykey-gui and pk commands don't work after installation (the only thing that works atm is running from the start menu)
  2. when pk-gui comes up, there is an error saying:
Error: Image could not be created from ..../static/logo.png
  1. tray icon doesn't work in the installed app (probably has something to do with not being able to create the image from the logo.png above)

@gideonairex
Copy link
Contributor

Added tailwind so that we can easily create our composable components.

Pushed sample usage on App.vue.

On tailwind.config.js this file will control our own theme.
Added postcss-loader so that tailwind will compile on webpack build.

@gideonairex gideonairex merged commit 310a582 into master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging this pull request may close these issues.

Migration to Vue 3 and Vuex 4 (supported by TypeScript-Demo-SPA) MVP Target October 31st
3 participants