Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: upgrade phpunit from 8.5.30 to 9.5.24 #337

Merged
merged 1 commit into from
Oct 20, 2022
Merged

upkeep: upgrade phpunit from 8.5.30 to 9.5.24 #337

merged 1 commit into from
Oct 20, 2022

Conversation

Sidsector9
Copy link
Contributor

@Sidsector9 Sidsector9 commented Oct 17, 2022 •
edited
Loading

Description of the Change

PHPUnit 8.5.30 uses a vulnerable version of jQuery, which is resolved by 9.5.24.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Security: bump PHPUnit from phpunit from 8.5.30 to 9.5.24

Credits

Props @Sidsector9

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul requested a review from faisal-alvi October 17, 2022 16:10
@jeffpaul jeffpaul added this to the 1.3.0 milestone Oct 17, 2022
faisal-alvi
faisal-alvi approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 this lookgs good, however the PHP Compat test for PHP 8.0 is failing. And I noticed its failing since 4b0703a. Approving this PR as that failure does not seem coming from this PR.

@jeffpaul jeffpaul merged commit da6dc67 into develop Oct 20, 2022
@jeffpaul jeffpaul deleted the phpunit-upgrade branch October 20, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Sidsector9 @faisal-alvi @jeffpaul