update sectionNames
to be same as allSections
in content-sync.php
#308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Somewhere between versions 1.0.5 and 1.1.1 we updated both
sectionNames
andallSections
fields in different requests, but somehow did not end up in the current ideal state where they're sending the literal same data. In testing with Vijay Jayaseelan and Arijit Paul today (sorry, I don't have their GitHub handles to @mention) we determined that the individual category names fromallSections
is the expected data for Sophi and not the category paths fromsectionNames
. So this PR updates thesectionNames
field to have the individual category names likeallSections
.Note that once this change is merged into
develop
and tested on a test site, we'll want to get this into a release so it can be confirmed and then make the final change in #141 to close out that issue.Relates to #301 and #141.
Alternate Designs
n/a
Possible Drawbacks
none identified
Verification Process
Check the content sync data sent to Sophi and see that it sends the same data for
sectionNames
andallSections
and that its the individual categories and not the category paths.Checklist:
Changelog Entry
Credits
Props @jeffpaul, Vijay Jayaseelan.