Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sectionNames to be same as allSections in content-sync.php #308

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

jeffpaul
Copy link
Contributor

Description of the Change

Somewhere between versions 1.0.5 and 1.1.1 we updated both sectionNames and allSections fields in different requests, but somehow did not end up in the current ideal state where they're sending the literal same data. In testing with Vijay Jayaseelan and Arijit Paul today (sorry, I don't have their GitHub handles to @mention) we determined that the individual category names from allSections is the expected data for Sophi and not the category paths from sectionNames. So this PR updates the sectionNames field to have the individual category names like allSections.

Note that once this change is merged into develop and tested on a test site, we'll want to get this into a release so it can be confirmed and then make the final change in #141 to close out that issue.

Relates to #301 and #141.

Alternate Designs

n/a

Possible Drawbacks

none identified

Verification Process

Check the content sync data sent to Sophi and see that it sends the same data for sectionNames and allSections and that its the individual categories and not the category paths.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - sectionNames and allSections in content-sync.php both contain individual categories from posts

Credits

Props @jeffpaul, Vijay Jayaseelan.

@jeffpaul jeffpaul added this to the 1.2.0 milestone Jul 12, 2022
@jeffpaul jeffpaul requested a review from YMufleh July 12, 2022 19:24
@jeffpaul jeffpaul self-assigned this Jul 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@YMufleh YMufleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants