Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/247 a $result is used instead of $request #277

Merged
merged 2 commits into from
May 16, 2022
Merged

Fix/247 a $result is used instead of $request #277

merged 2 commits into from
May 16, 2022

Conversation

faisal-alvi
Copy link
Contributor

@faisal-alvi faisal-alvi commented May 16, 2022 •
edited
Loading

Description of the Change

This PR simply changes the variable names.

Closes #247

Alternate Designs

n/a

Possible Drawbacks

#247 (comment)

Verification Process

This is just a variable name change, does not tweak any logic, though, a quick test of the plugin functionalities would be great.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - $result is used instead of $request to store return value of the sophi_request_result filter.

@faisal-alvi faisal-alvi added this to the 1.1.1 milestone May 16, 2022
@faisal-alvi faisal-alvi self-assigned this May 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@faisal-alvi faisal-alvi requested a review from Sidsector9 May 16, 2022 10:31
@faisal-alvi faisal-alvi marked this pull request as ready for review May 16, 2022 10:31
Sidsector9
Sidsector9 approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jeffpaul jeffpaul merged commit d688216 into develop May 16, 2022
@jeffpaul jeffpaul deleted the fix/247 branch May 16, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@faisal-alvi faisal-alvi

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Fix incorrect variable names
3 participants
@faisal-alvi @Sidsector9 @jeffpaul