Same ruff linting as jf-remote
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ml-evs would be great if you could have a look at these changes! 🙏 |
|
Thanks @janosh, this PR fine in principle, but would prefer to hold off until #43 is worked on a bit to avoid unnecessary churn, and probably to wait until @gpetretto is back from vacation for a final check. |
… an Error suffix
gpetretto
force-pushed
the
same-ruff-linting-as-jf-remote
branch
from
2a3ba1c to
cf6f479
Compare
|
Hi @janosh, just wanted to notify you that, since we wanted to finalize this before making a new release of qtoolkit, I updated your PR to the latest commits and fixed the remaining linting issues. |
davidwaroquiers
approved these changes
Jan 20, 2025
Comment on lines
+8
to
+10
| authors = [ | ||
| { name = "David Waroquiers", email = "david.waroquiers@matgenix.com" }, | ||
| ] |
There was a problem hiding this comment.
Not really related to this PR but I'd add other authors here no ? Who ?
|
Thanks all for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equivalent
qtoolkitPR to Matgenix/jobflow-remote#134