-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project check #158
Project check #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments on the changes. I think there is a bug in the original version of the check. Maybe it can be fixed in this PR.
ac9996f
to
bb4247d
Compare
bb4247d
to
35f584e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 72.82% 73.08% +0.26%
===========================================
Files 47 47
Lines 6207 6249 +42
Branches 979 991 +12
===========================================
+ Hits 4520 4567 +47
+ Misses 1337 1329 -8
- Partials 350 353 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me (just one small comment/question regarding the check_worker but I leave it up to you to take the decision to do anything or not, be it a comment or changing the code). Thanks! Can't approve my own PR :D
e86e6ad
to
794ba90
Compare
Adding check on version compatibility between the runner and the workers.
This would have probably allowed to prevent #157 from happening (at least finding out the reason maybe ?).