Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project check #158

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Project check #158

merged 6 commits into from
Oct 24, 2024

Conversation

davidwaroquiers
Copy link
Member

Adding check on version compatibility between the runner and the workers.
This would have probably allowed to prevent #157 from happening (at least finding out the reason maybe ?).

Copy link
Contributor

@gpetretto gpetretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments on the changes. I think there is a bug in the original version of the check. Maybe it can be fixed in this PR.

src/jobflow_remote/cli/project.py Show resolved Hide resolved
src/jobflow_remote/config/helper.py Outdated Show resolved Hide resolved
src/jobflow_remote/config/helper.py Outdated Show resolved Hide resolved
src/jobflow_remote/config/helper.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.08%. Comparing base (294e8f4) to head (794ba90).

Files with missing lines Patch % Lines
src/jobflow_remote/config/helper.py 65.11% 8 Missing and 7 partials ⚠️
src/jobflow_remote/cli/project.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    72.82%   73.08%   +0.26%     
===========================================
  Files           47       47              
  Lines         6207     6249      +42     
  Branches       979      991      +12     
===========================================
+ Hits          4520     4567      +47     
+ Misses        1337     1329       -8     
- Partials       350      353       +3     
Files with missing lines Coverage Δ
src/jobflow_remote/cli/project.py 85.18% <85.71%> (+9.61%) ⬆️
src/jobflow_remote/config/helper.py 69.17% <65.11%> (+0.75%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member Author

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me (just one small comment/question regarding the check_worker but I leave it up to you to take the decision to do anything or not, be it a comment or changing the code). Thanks! Can't approve my own PR :D

src/jobflow_remote/cli/project.py Outdated Show resolved Hide resolved
@davidwaroquiers davidwaroquiers changed the title [WIP] Project check Project check Oct 24, 2024
@gpetretto gpetretto merged commit d075299 into develop Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants