Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/fix validations #92

Merged
merged 8 commits into from
Jul 26, 2024
Merged

update/fix validations #92

merged 8 commits into from
Jul 26, 2024

Conversation

mustafasoylu
Copy link
Collaborator

Update poetry, package.json and julia models and writer for person validation. Now, we dont raise an error when the person doesnt have email information, we ignore that input and print a warning message. This also fixes #87

closes #87

@mustafasoylu mustafasoylu added bug Something isn't working enhancement New feature or request labels Jul 23, 2024
@mustafasoylu mustafasoylu added this to the v0.4.3 milestone Jul 23, 2024
@mustafasoylu mustafasoylu self-assigned this Jul 23, 2024
@mustafasoylu mustafasoylu merged commit f42047b into main Jul 26, 2024
16 checks passed
@mustafasoylu mustafasoylu deleted the fix/validations branch July 26, 2024 13:15
@mustafasoylu mustafasoylu restored the fix/validations branch July 26, 2024 13:20
@mustafasoylu mustafasoylu deleted the fix/validations branch July 26, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional fields treated as required
1 participant