Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config #31

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Fix config #31

merged 3 commits into from
Jul 27, 2023

Conversation

apirogov
Copy link
Contributor

This resolves issues discovered while using the pre-commit hook. Main changes:

  • Refactored somesy input handling to be more consistent
  • Main input model is now SomesyInput
  • possibly broke current state of init_config, should be addressed in somesy config harvesting with hermes #9 after this is merged

mustafasoylu
mustafasoylu approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@mustafasoylu mustafasoylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apirogov apirogov merged commit cd7e5e9 into main Jul 27, 2023
7 checks passed
@apirogov apirogov deleted the fix-config branch July 27, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafasoylu mustafasoylu mustafasoylu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apirogov @mustafasoylu