k8s-orchestrator: create a StatefulSet per process #31629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
k8s-orchestrator-multiple-statefulsets
branch
2 times, most recently
from
b9814bf to
9457444
Compare
teskje
changed the title
This commit changes the k8s orchestrator to create a separate statefulset for each process requested, instead of using a single statefulset with multiple replicas. This is to allow us to supply different configurations to different cluster processes. In particular, we want to be able to provide each process with its index through a command line argument.
teskje
force-pushed
the
k8s-orchestrator-multiple-statefulsets
branch
from
9457444 to
ecd95ff
Compare
teskje
commented
Feb 26, 2025
Comment on lines
+1209
to
+1212
| selector: LabelSelector { | ||
| match_labels: Some(match_labels.clone()), | ||
| ..Default::default() | ||
| }, |
There was a problem hiding this comment.
I'm unsure of this part: The pod selector for each StatefulSet also selects the pods from other processes' StatefulSets, which seems like it would be a problem, but things seem to work anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the k8s orchestrator to create a separate statefulset for each process requested, instead of using a single statefulset with multiple replicas.
This is to allow us to supply different configurations to different cluster processes. In particular, we want to be able to provide each process with its index through a command line argument.
Motivation
See thread and thread.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.