[poc] cluster/communication: turmoil test for create_sockets #31591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a chaos simulation for `create_sockets` using the turmoil library. The test runs a number of processes and instructs them to connect to each other, while simulating multiple controller reconnects with increasing epochs. Turmoil simulates the network, so it requires the use of its own `TcpStream` types within the test. To enable that, support for the turmoil TCP types is added to `mz-ore::netio`. Run the test once with `cargo test -p mz-cluster`. Or use it for fuzzing with `cargo test -p mz-cluster -- --ignored fuzz`. Note that the test is currently failing unreliable. Dropping the `create_sockets` future in a process can make other processes hang attempting to connect to that process. It's unclear whether this is a bug in turmoil or something we should expect given the absence of network timeouts in `create_sockets`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a chaos simulation for
create_socketsusing the turmoil library. The test runs a number of processes and instructs them to connect to each other, while simulating multiple controller reconnects with increasing epochs.Run the test once with
cargo test -p mz-cluster. Or use it for fuzzing withcargo test -p mz-cluster -- --ignored fuzz.Note that the test is currently unreliable. Dropping the
create_socketsfuture in a process can make other processes hang attempting to connect to that process. It's unclear whether this is a bug in turmoil or something we should expect given the absence of network timeouts increate_sockets.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.