Fix nightly Rust build of prost #20041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think have to land MaterializeInc/prost#4 first. |
|
Looking at Cargo.toml, it seems like the reason we had to fork prost in the
first place has been fixed. Can you see if we could switch back to the
latest prost-build release instead? (crates.io dependencies don’t trigger a
pull of the submodule; the package itself bundles the submodule code.)
…On Tue, Jun 20, 2023 at 9:44 AM Dennis Felsing ***@***.***> wrote:
I think have to land MaterializeInc/prost#4
<MaterializeInc/prost#4> first.
—
Reply to this email directly, view it on GitHub
<#20041 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGXSIFY4LGONYVETVIRV6LXMGSL3ANCNFSM6AAAAAAZNJZT44>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
def-
force-pushed
the
pr-fix-nightly-build-prost
branch
from
43ffd47
to
d7449ca
Compare
|
Seems to work, done. |
def-
force-pushed
the
pr-fix-nightly-build-prost
branch
2 times, most recently
from
36603ae
to
bc0d5c3
Compare
|
Actually my bad. prost v0.11.9 did not contain tokio-rs/prost#833, so we still have the same problem with prettyplease. I'm guessing prost v0.12.0 needs to be released to fix that first. |
def-
force-pushed
the
pr-fix-nightly-build-prost
branch
from
bc0d5c3
to
43ffd47
Compare
|
I think just allow the duplicate dependency in deny.toml. Seems better than having to manage a bunch of patches for this. |
by going back to upstream prost version error: failed to load source for dependency `prost` Caused by: Unable to update https://github.com/MaterializeInc/prost#17cc373b Caused by: failed to update submodule `prost-build/third-party/protobuf` Caused by: failed to parse url for submodule `prost-build/third-party/protobuf`: `git@github.com:protocolbuffers/protobuf` Caused by: relative URL without a base
def-
force-pushed
the
pr-fix-nightly-build-prost
branch
from
43ffd47
to
6f264c1
Compare
benesch
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses MaterializeInc/prost#4
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.