Add login_customer_id config #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @spencerjbeckwith - this looks good to me. Just wanna test on our side and then we can merge. 🙂 |
|
Very timely, I just got another account added to my manager. Turns out I was setting For future improvements, would you consider making customer ids iterable? Or making the tap return all the relevant data for accounts under the manager? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the value of the
login-customer-idheader to the same value as the syncingcustomer_idprevents using this tap with a manager account.This PR makes the
login-customer-idheader a separate and optional config property (login_customer_id) so manager accounts can be used. If not specified, thelogin-customer-idheader will still be set to the configuredcustomer_id.