[Hall of Fame]2 - Card template #464
Conversation
|
Hello. You can customize the container to align the content. |
Hello, Bohdan worked with the text, so I think it would be correct to write to him about the text on the page |
…andrummer' into 11-hall_of_fame_card_template_NosatskyiK
vladyslav-yermolin-moc
changed the title
docs/index.html
Outdated
| <template data-template> | ||
| <section class="card"> | ||
| <div class="card__information"> | ||
| <div class="card__information-img"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
docs/index.html
Outdated
| <div class="card__information-img"> | ||
| <img class="card__img" src="_img/title_pokemon.png" alt="pokemon" data-template-image> | ||
| </div> | ||
| <div class="card__information-title"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
docs/index.html
Outdated
| </div> | ||
| <div class="card__social"> | ||
| <a href="#" class="social__link"> | ||
| <div class="card__social-github"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
docs/index.html
Outdated
| </div> | ||
| </a> | ||
| <a href="#" class="social__link"> | ||
| <div class="card__social-gmail"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
docs/index.html
Outdated
| </div> | ||
| </a> | ||
| <a href="#" data-telegram class="social__link"> | ||
| <div class="card__social-telegram"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
docs/index.html
Outdated
| </div> | ||
| </a> | ||
| </div> | ||
| <div class="card__btn"> |
There was a problem hiding this comment.
unnecessary element and class are not used.
There was a problem hiding this comment.
removed unused tag classes
|
Hey, guys, I've added some minor styles corrections, and going to make a code-review |
|
The icons in the footer are blocked by CORS |
|
Ok, the Github pages don't like the underscores in the file name (probably). |
There was a problem hiding this comment.
What a name!!!)))
Please use more common: reset or normalize.css
| } | ||
|
|
||
| .main__title { | ||
| font-family: Roboto sans-serif; |
There was a problem hiding this comment.
Something wrong with font connection - please don't forget to add safe font and tune up connection of Roboto properly
There was a problem hiding this comment.
Probably, the card.css would be more suitable name
There was a problem hiding this comment.
Please add some suitable name for this file
|
I'm going to merge this pr, but fixes of my comments here are on you, @NosatskyiK |
No description provided.