Update "ternary" to use "template.IsTrue" #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts `ternary` to use the same `template.IsTrue` that controls the semantics of the built-in `if` (and friends). For further context, `template.IsTrue` has been officially exported since Go 1.6 (golang/go@a326c3e).
tianon
force-pushed
the
ternary-iftrue
branch
from
0c84c36 to
32d2c88
Compare
tianon
commented
Dec 22, 2020
| func ternary(vt interface{}, vf interface{}, v bool) interface{} { | ||
| if v { | ||
| func ternary(vt interface{}, vf interface{}, v interface{}) interface{} { | ||
| if truth, ok := template.IsTrue(v); ok && truth { |
There was a problem hiding this comment.
In my own library, I'd implemented this with a panic for !ok (which I'm happy to adjust this to), but I wasn't sure if panic was appropriate here. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 ❤️
I looked into Sprig today because it implements many functions my own hand-rolled library was, in most cases with the same name/signature! Thank you for creating such a cool project.
One minor difference between my own
ternaryand the one provided by Sprig is that mine acceptsinterface{}instead ofbooland uses the officialtemplate.IsTruefunction that controls the semantics of the built-inif(and friends) to convertinterface{}intobool(for further context,template.IsTruehas been officially exported since Go 1.6: golang/go@a326c3e).Given that this would make
ternarymatch the semantics ofif, it felt like an appropriate change, and it was simple enough that I thought discussing over a concrete PR might be the easiest way to see if this is something that you'd be interested in. 😄Just to be explicit, I'm happy to adjust, rebase, amend, discuss, close, etc! ❤️