Merge pull request #258 from Link1515/fix/duplicate-attributes

Ignore duplicate attributes
Masterminds · Feb 15, 2025 · b2375ac · b2375ac
2 parents ab71073 + 1660321
commit b2375ac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/HTML5/Parser/Tokenizer.php b/src/HTML5/Parser/Tokenizer.php
@@ -507,7 +507,7 @@ protected function attribute(&$attributes)
         $this->scanner->whitespace();
 
         $val = $this->attributeValue();
-        if ($isValidAttribute) {
+        if ($isValidAttribute  && !array_key_exists($name, $attributes)) {
             $attributes[$name] = $val;
         }
 

diff --git a/test/HTML5/Parser/TokenizerTest.php b/test/HTML5/Parser/TokenizerTest.php
@@ -705,6 +705,14 @@ public function testTagAttributes()
                 ),
                 false,
             ),
+            // duplicate attributes must be ignored
+            '<foo bar="first" bar="second">' => array(
+                'foo',
+                array(
+                    'bar' => 'first',
+                ),
+                false,
+            ),
         );
         $this->isAllGood('startTag', 2, $good);