Preserve .git file correctly #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vendor is a submodule, .git is a file (not a directory). When /tmp is on a different filesystem, we try to copy it as a directory which leaves an empty .git directory instead of the file. This change fixes this by copying it as a file in this case. Fixes Masterminds#828.
|
@sdboyer did you get a chance to look at this in between all the dep work? |
|
@dt hah, i didn't even see it, thanks for the ping. I totally never knew that submodules did this. Huh. Since 1.7.8, it seems...I wonder how I missed it for so long. Anyway, LGTM - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vendor is a submodule, .git is a file (not a directory). When /tmp is on a
different filesystem, we try to copy it as a directory which leaves an empty
.git directory instead of the file. This change fixes this by copying it as a
file in this case.
Fixes #828.
This change is