Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glide requires $GOPATH, but Go 1.8 doesn't #771

Closed
treeder opened this issue Feb 19, 2017 · 4 comments
Closed

Glide requires $GOPATH, but Go 1.8 doesn't #771

treeder opened this issue Feb 19, 2017 · 4 comments
Milestone
0.13

Comments

@treeder
Copy link

treeder commented Feb 19, 2017

Glide should use the default of $HOME/go if not set.
@mattfarina
Copy link
Member

I wonder if we could use go env GOPATH if the GOPATH env var is empty. That may give us the right result.

@jmalloc jmalloc mentioned this issue Mar 23, 2017
Closed
@jmalloc
Copy link

jmalloc commented Mar 23, 2017

I am using go env in Makefiles for similar reasons, and can confirm that it gives the correct results under 1.8 when $GOPATH is not set :)

jmalloc added a commit to jmalloc/dotfiles that referenced this issue Apr 1, 2017
@jmalloc
Explicitly set GOPATH to the default to work around Masterminds/glide…
eb2c368 
…#771
mattfarina added a commit that referenced this issue Apr 7, 2017
@mattfarina
Fixes #771: Handling default GOPATH for Go 1.8
248aaca 
In Go 1.8 a default GOPATH was introduced. This can be retrieved
using `go env GOPATH`. This change updates Glide to check for a
default value when the GOPATH is not set. The reason to invode the
go toolchain as a second step is to avoid invoking it if possible.
@mattfarina mattfarina added this to the 0.13 milestone Apr 7, 2017
@mattfarina
Copy link
Member

There's a PR for this on #798

mattfarina added a commit that referenced this issue Apr 10, 2017
@mattfarina
Merge pull request #798 from Masterminds/feat/gopath-1.8
4b59f9a 
Fixes #771: Handling default GOPATH for Go 1.8
@comerc
Copy link

comerc commented May 29, 2017 

$ glide install
[ERROR]	$GOPATH is not set.

$ glide -v
glide version v0.12.3

go version go1.8.3 linux/amd64

Ubuntu 14.04.5 LTS

@iwankgb iwankgb mentioned this issue Sep 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
4 participants
@mattfarina @treeder @jmalloc @comerc