Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored dependency in testImports #505

Closed
bakks opened this issue Jul 7, 2016 · 4 comments
Closed

Ignored dependency in testImports #505

bakks opened this issue Jul 7, 2016 · 4 comments
Labels
Milestone

Comments

@bakks
Copy link

bakks commented Jul 7, 2016

I have a project with a glide.yaml file with the following (among other things):

ignore:
  - common
  - common/http

This project has a test file that imports common/http. After running glide update on v0.11.0 I see the following in my glide.lock

testImports:
- name: common/http
  version: ""

Basically an explicitly ignored module is showing up in the in glide.lock. I'm aware that doing relative imports in this way isn't the advised pattern. However - this was pretty unexpected behavior and I would guess is a bug? The reason I noticed it was that it broke the glide install I ran later on.

Hope this is helpful, let me know if any more clarification would be useful.

@mattfarina mattfarina added the bug label Jul 7, 2016
@mattfarina
Copy link
Member

Thanks for filing the bug. I usually follow up a change release with at least one bug release before we work on more interesting changes. I'll add this to that release which should be out in the next week.

@mattfarina mattfarina added this to the 0.11.1 milestone Jul 7, 2016
@charneykaye
Copy link

Same thing happening to us here. Every time we add deps via glide get or do a glide update these dependencies that ought to be ignored keep being re-added to the glide.lock file under testImports only. Thanks!

@mattfarina
Copy link
Member

I believe #512 fixes this. If there are no issues found I'll merge on Tuesday.

mattfarina added a commit that referenced this issue Jul 19, 2016
Fixed #505: Ignored packages can still be resolved
@bakks
Copy link
Author

bakks commented Jul 23, 2016

Just to confirm - I ran glide upgrade on my project using v0.11.1 and the issue appears to have been resolved. Thanks for fixing - Glide is awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants