[CodeArena] - [L-14] : Constructor parameters validation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,13 @@ contract NestedFactory is INestedFactory, ReentrancyGuard, Ownable, MixinOperato | |||
| IWETH _weth, | |||
| address _operatorResolver | |||
| ) MixinOperatorResolver(_operatorResolver) { | |||
| require( | |||
There was a problem hiding this comment.
Should we add a check on _operatorResolver in the constructor of this file MixinOperatorResolver as well?
There was a problem hiding this comment.
Added the check for _operatorResolver
adrien-supizet
removed
the
To review
|
Rebase and update the require message with the new standard |
maximebrugel
force-pushed
the
codearena-178
branch
from
ebff579
to
93260fd
Compare
maximebrugel
added
Can merge
maximebrugel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue => code-423n4/2021-11-nested-findings#178