Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marvell sai package file name format issue #62

Open
xumia opened this issue Feb 13, 2022 · 3 comments · Fixed by sonic-net/sonic-buildimage#10126
Open

Marvell sai package file name format issue #62

xumia opened this issue Feb 13, 2022 · 3 comments · Fixed by sonic-net/sonic-buildimage#10126

Comments

@xumia
Copy link

xumia commented Feb 13, 2022 •
edited
Loading

The debian package name should be as below:

<PackageName>_<VersionNumber>-<DebianRevisionNumber>_<DebianArchitecture>.deb

Could you please change the name from mrvllibsai_armhf_1.7.1_01.deb to mrvllibsai_1.7.1-01_armhf.deb (only an example)? And fix all the packages? It is good to fix on the new release packages.
It has impact on some of the downstream pipelines to parse the version part.

  1. Version should be placed on the second part, not the third part.
  2. Version should not contain "_".
@xumia
Copy link
Author

xumia commented Feb 13, 2022

@rajkumar38 , could you please take a look the issue?

This was referenced Feb 13, 2022
Merged
Merged
Closed
@rajkumar38
Copy link
Contributor

rajkumar38 commented Feb 18, 2022 •
edited
Loading

@rajkumar38 , could you please take a look the issue?

We will fix this.

@rajkumar38 rajkumar38 mentioned this issue Mar 2, 2022
Merged
6 tasks
@rajkumar38
Copy link
Contributor

Raised PR sonic-net/sonic-buildimage#10126

@rajkumar38 rajkumar38 mentioned this issue Mar 2, 2022
Merged
6 tasks
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this issue Mar 4, 2022
@rajkumar38
[Marvell] Update armhf driver/sai deb version (#10126)
b400a64 
Fixed Marvell SAI deb version naming issue reported in Marvell-switching/sonic-marvell-binaries#62

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this issue Mar 5, 2022
@rajkumar38
[Marvell][build] Marvell armhf SAI debian. (#10130)
1bdc7f0 
- Fixed SAI debian version name issue reported in Marvell sai package file name format issue Marvell-switching/sonic-marvell-binaries#62
- Implement DHCP, DHCv6 traps as per SAI Specifications
- Added support to return SAI_STATUS_NOT_SUPPORTED for ERSPAN feature [Nokia-7215] [marvell] orchagent exited when activating mirror_session #9830

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
zjswhhh pushed a commit to sonic-net/sonic-buildimage that referenced this issue Mar 7, 2022
@rajkumar38 @zjswhhh
[Marvell][build] Marvell armhf SAI debian. (#10130)
d06f0b0 
- Fixed SAI debian version name issue reported in Marvell sai package file name format issue Marvell-switching/sonic-marvell-binaries#62
- Implement DHCP, DHCv6 traps as per SAI Specifications
- Added support to return SAI_STATUS_NOT_SUPPORTED for ERSPAN feature [Nokia-7215] [marvell] orchagent exited when activating mirror_session #9830

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
@xumia xumia mentioned this issue Mar 31, 2022
Merged
6 tasks
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this issue Apr 1, 2022
@rajkumar38 @xumia
[Marvell] Update armhf driver/sai deb version (sonic-net#10126)
8199c91 
Fixed Marvell SAI deb version naming issue reported in Marvell-switching/sonic-marvell-binaries#62

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
xumia added a commit to sonic-net/sonic-buildimage that referenced this issue Apr 1, 2022
@xumia
[Build]: Fix armhf 202111 build broken issue (#10423)
7ddad86 
* [Marvell] Update armhf SAI deb version 1.9.1 (#9865)

Move marvell armhf SAI deb to 1.9.1 to address build failures.

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>

* [Marvell] Update armhf driver/sai deb version (#10126)

Fixed Marvell SAI deb version naming issue reported in Marvell-switching/sonic-marvell-binaries#62

Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>

* [Build]: only install grpc in amd64 (#10212)

[Build]: only install grpc in amd64
Unblock marvell-armhf build.

Co-authored-by: Rajkumar-Marvell <54936542+rajkumar38@users.noreply.github.com>

Why I did it
Cherry-pick commits from master to 202111 to fix build broken issue.
See detail in the commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Marvell] Update armhf driver/sai deb version
2 participants
@rajkumar38 @xumia