Fixed porstat rate and util issues. #2
Conversation
|
@antony-rheneus @banagiri @radha-danda |
| rate = "{:.2f}".format(rate/1024/1024)+' MB' | ||
| elif rate > 1024*10: | ||
| rate = "{:.2f}".format(rate/1024)+' KB' | ||
| if rate > 1000*1000*10: |
There was a problem hiding this comment.
It should not be 1000.
1024 is the correct value.
There was a problem hiding this comment.
For throughput calculation against the link speed, factor has to be 1000 and not 1024.
https://my.ciena.com/CienaPortal/s/question/0D50z00005JK3dQCAT/ethernet-packet-rate-and-throughput-calculations
There was a problem hiding this comment.
the reference mentions to convert Link speed in 1000's instead of 1024.
Here we are converting frame size, not the speed
| util = rate/(port_rate*1024*1024*1024/8.0)*100 | ||
| return "{:.2f}%".format(util) | ||
| util = rate/(port_rate*1000*1000*1000/8.0)*100 | ||
| if util < 100: |
There was a problem hiding this comment.
I dont think this is right way
There was a problem hiding this comment.
Any suggestion, If we don't round-off, value sometimes looks like 100.05%. This is because of time delta is not accurate.
There was a problem hiding this comment.
If you update 1024, itw ould not be more than 100%
Even with 1024, if it is more than 100%, then the overhead crosses the link speed itself.
- What I did
Fixed "portstat" rate and utilization issue.
Changed size factor from 1024 to 1000 for rate throughput calculation.
- How I did it
Pls check the diff.
- How to verify it
"portstat" "portstat -a"
- Previous command output (if the output of a command-line utility has changed)
IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_UTIL TX_ERR TX_DRP TX_OVR
Ethernet41 U 353,628,250 98.67 MB/s 1.93% 0 0 0 353,660,334 98.67 MB/s 1.93% 0 0 0
- New command output (if the output of a command-line utility has changed)
IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_UTIL TX_ERR TX_DRP TX_OVR
Ethernet2 U 5,065,263,485 124.98 MB/s 99.99% 0 0 0 113 7.63 B/s 0.00% 0 0 0