Code-Quality

fix(deps): update dependency @apollo/client to v3.10.3 (#1785) #1169

Triggered via push May 7, 2024 18:06

renovate[bot]

pushed c3d45da

master

Status Success

Total duration 2m 41s

Artifacts –

qodana-cloud.yml

on: push

qodana

2m 32s

Annotations

7 errors, 80 warnings, and 1 notice

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L24

'spoon.javadoc.internal.JavadocDescriptionElement' is deprecated and marked for removal

Usage of API marked for removal: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/size_replaceable_by_is_empty/SizeReplaceableByIsEmptyAnalyzer.java#L80

'BOOLEAN' is deprecated and marked for removal

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L267

'spoon.javadoc.internal.JavadocDescriptionElement' is deprecated and marked for removal

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L270

'spoon.javadoc.internal.JavadocInlineTag' is deprecated and marked for removal

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L270

'spoon.javadoc.internal.JavadocInlineTag' is deprecated and marked for removal

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L25

'spoon.javadoc.internal.JavadocInlineTag' is deprecated and marked for removal

Usage of API marked for removal: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L269

'spoon.javadoc.internal.JavadocInlineTag' is deprecated and marked for removal

Redundant 'Collection.addAll()' call: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/formatting/GoogleStyle.java#L21

'addAll()' call can be replaced with parametrized constructor call

Nullability and data flow problems: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L22

Method invocation `getPath` may produce `NullPointerException`

Default annotation parameter value: github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java#L42

Redundant default parameter value assignment

Deprecated API usage: github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/MiningStartup.java#L35

'setWorker(boolean)' is deprecated

Double negation: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/array_can_be_replaced_with_enum_values/ArrayCanBeReplacedWithEnumValuesAnalyzer.java#L45

Double negation in `!(declaration.getEnumValues().size() != count)`

Statement with empty body: code-transformation/src/main/java/spoon/reflect/visitor/ImportAnalyzer.java#L156

`if` statement has empty body

Statement with empty body: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/LambdaToExecutableReference.java#L49

`if` statement has empty body

Statement with empty body: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L300

`if` statement has empty body

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/TransformationEngine.java#L37

Field `processors` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L17

Field `property` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethodAnalyzer.java#L17

Field `filter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L20

Field `endLine` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L10

Field `text` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L11

Field `markdownText` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/ChangeListener.java#L14

Field `changelog` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L18

Field `startLine` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/ChangeListener.java#L13

Field `changedTypes` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/formatting/ImportGrouper.java#L12

Field `style` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/equals_hashcode/EqualsHashcode.java#L13

Field `affectedType` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L15

Field `affectedType` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L15

Field `affectedType` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/Index_off_replaceable_by_contains/IndexOfReplaceableByContainsAnalyzer.java#L23

Field `matcher` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/ImportHelper.java#L86

Field `importString` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/api/MiningGraphQL.java#L15

Field `analyzerRunRepository` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L16

Field `affectedMethod` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L151

Field `typeRefQNames` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L148

Field `compilationUnit` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Link.java#L5

Field `url` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L14

Field `issue` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/printing/ChangedTypePrinting.java#L11

Field `prettyPrinter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L149

Field `computedImports` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L21

Field `endColumn` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java#L36

Field `issueRequestService` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Changelog.java#L8

Field `changes` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L13

Field `text` may be 'final'

Inner class may be 'static': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/access_static_via_instance/AccessStaticViaInstanceAnalyzer.java#L29

Inner class `StaticInvocationFilter` may be 'static'

Javadoc declaration problems: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L19

`@param affectedType` tag description is missing

Javadoc declaration problems: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L20

`@param affectedMethod` tag description is missing

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L61

Cannot resolve symbol `ImportConflictDetector`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L5

Cannot resolve symbol `asMarkdown`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L5

Cannot resolve symbol `asString`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/util/Nullsafe.java#L32

Cannot resolve symbol

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L40

Casting `element.getBody().getLastStatement()` to `CtReturn` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/BooleanExpression.java#L31

Casting `element.getLeftHandOperand()` to `CtExpression` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L22

Casting `getFactory().Type().createReference(...)` to `CtTypeReference` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/migration/ExpectedExceptionRemoval.java#L110

Casting `getFactory().Type().voidType()` to `CtTypeReference` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L37

Casting `new NewLineAnnotation<>()` to `NewLineAnnotation` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L50

Casting `thenBlock.getStatement(...)` to `CtReturn` is redundant

Redundant 'File' instance creation: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L23

`new File` is redundant

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseSameCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseEqualsCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueSameCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueEqualsCheck.java#L85

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNotNullTransformation.java#L103

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java#L103

Redundant call to `format()`

Stream API call chain can be simplified: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/ProtectedMemberInFinalType.java#L42

'collect(toList())' can be replaced with 'toList()'

Stream API call chain can be simplified: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/CollectionEmptyCheck.java#L62

'collect(toList())' can be replaced with 'toList()'

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L32

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L58

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Changelog.java#L30

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L69

String concatenation as argument to `StringBuilder.append()` call

Minimum 'switch' branches: github-bot/src/main/java/io/github/martinwitt/laughing_train/services/SpoonAnalyzerService.java#L27

'switch' statement has too few case labels (1), and should probably be replaced with an 'if' statement

Minimum 'switch' branches: github-bot/src/main/java/io/github/martinwitt/laughing_train/refactor/RefactorService.java#L79

'switch' statement has too few case labels (1), and should probably be replaced with an 'if' statement

Call to 'printStackTrace()': github-bot/src/main/java/io/github/martinwitt/laughing_train/Config.java#L92

Call to `printStackTrace()` should probably be replaced with more robust logging

Redundant 'if' statement: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/EmptyStringCheck.java#L50

`if` statement can be simplified

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/ThreadLocalWithInitial.java#L124

Unchecked cast: 'spoon.reflect.code.CtStatement' to 'spoon.reflect.code.CtReturn'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L22

Unchecked assignment: 'spoon.reflect.reference.CtTypeReference' to 'spoon.reflect.reference.CtTypeReference'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/LambdaToExecutableReference.java#L63

Unchecked assignment: 'spoon.reflect.reference.CtExecutableReference' to 'spoon.reflect.reference.CtExecutableReference'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L32

Unchecked assignment: 'spoon.reflect.code.CtExpression' to 'spoon.reflect.code.CtExpression'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L37

Unchecked cast: 'xyz.keksdose.spoon.code_solver.spoon.NewLineAnnotation' to 'xyz.keksdose.spoon.code_solver.spoon.NewLineAnnotation'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/BooleanExpression.java#L31

Unchecked cast: 'spoon.reflect.code.CtExpression\>' to 'spoon.reflect.code.CtExpression'

Unchecked warning: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/size_replaceable_by_is_empty/SizeReplaceableByIsEmptyAnalyzer.java#L52

Unchecked assignment: 'java.util.Optional' to 'java.util.Optional\>'

Unchecked warning: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/size_replaceable_by_is_empty/SizeReplaceableByIsEmptyAnalyzer.java#L87

Unchecked call to 'setOperand(CtExpression)' as a member of raw type 'spoon.reflect.code.CtUnaryOperator'

Redundant local variable: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java#L30