Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404PageWithIcon #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

404PageWithIcon #14

wants to merge 3 commits into from

Conversation

Dev-Ahmadubah
Copy link

@Dev-Ahmadubah Dev-Ahmadubah commented Apr 1, 2023

A 404 page with an Icon
404

@sidiDev
Copy link
Member

sidiDev commented Apr 1, 2023

Hi @Dev-Ahmadubah Please give more information about this PR, and the next time make sure to open an issue of what you want to work on, or to improve ...etc before creating PRs, you can also read the contribution guidelines here: https://github.com/MarsX-dev/floatui/blob/main/CONTRIBUTING.md

@Dev-Ahmadubah
Copy link
Author

Thanks for the feedback @sidiDev. I will work on that.

@sidiDev
Copy link
Member

sidiDev commented Apr 1, 2023

Thanks for the feedback @sidiDev. I will work on that.

Thanks for creating this component, can you please make it looks better, here are some steps you can follow to make it looks better:

  • Remove ":" from the Heading 1
  • Maybe you can replace font-medium with font-semibold in Heading 1
  • Improve the button below, you can replace it with a button from one of the 404 Pages buttons in Float UI.

@Dev-Ahmadubah
Copy link
Author

Thanks for the feedback @sidiDev. I will work on that.

Thanks for creating this component, can you please make it looks better, here are some steps you can follow to make it looks better:

  • Remove ":" from the Heading 1
  • Maybe you can replace font-medium with font-semibold in Heading 1
  • Improve the button below, you can replace it with a button from one of the 404 Pages buttons in Float UI.

Done

@sidiDev
Copy link
Member

sidiDev commented Apr 2, 2023

Can you please share a demo like a screenchot for example?

@Dev-Ahmadubah
Copy link
Author

Can you please share a demo like a screenchot for example?

Sure
Screenshot (463)

@Dev-Ahmadubah
Copy link
Author

@sidiDev is there any problem with component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants