Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API module # use OpenLineage model in OL resource #1593

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

OleksandrDvornik
Copy link
Contributor

PR for issue
Replace Marquez LineageEvent with OpenLineage model

Signed-off-by: olek <oleksandr.dvornik@gmail.com>
Signed-off-by: olek <oleksandr.dvornik@gmail.com>
Signed-off-by: olek <oleksandr.dvornik@gmail.com>
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1593 (e9ac681) into main (b5909ef) will decrease coverage by 0.04%.
The diff coverage is 96.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1593      +/-   ##
============================================
- Coverage     78.63%   78.59%   -0.05%     
+ Complexity      959      957       -2     
============================================
  Files           188      187       -1     
  Lines          5191     5134      -57     
  Branches        415      408       -7     
============================================
- Hits           4082     4035      -47     
+ Misses          670      660      -10     
  Partials        439      439              
Impacted Files Coverage Δ
...src/main/java/marquez/api/OpenLineageResource.java 71.42% <ø> (ø)
api/src/main/java/marquez/common/Utils.java 86.29% <ø> (ø)
...pi/src/main/java/marquez/db/DatasetVersionDao.java 95.77% <ø> (-0.06%) ⬇️
...i/src/main/java/marquez/service/models/NodeId.java 54.02% <0.00%> (+1.21%) ⬆️
api/src/main/java/marquez/db/OpenLineageDao.java 95.14% <100.00%> (-1.42%) ⬇️
api/src/main/java/marquez/db/RunDao.java 92.59% <100.00%> (ø)
.../main/java/marquez/service/OpenLineageService.java 96.38% <100.00%> (-0.21%) ⬇️
api/src/main/java/marquez/db/Columns.java 71.42% <0.00%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5909ef...e9ac681. Read the comment docs.

Signed-off-by: olek <oleksandr.dvornik@gmail.com>
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc
Copy link
Member

@OleksandrDvornik: just as a reminder, please link related issues in your PR descriptions, see our CONTRIBUTING.md

@wslulciuc wslulciuc merged commit 1a96320 into main Aug 26, 2021
@wslulciuc wslulciuc deleted the feature/use-ol-client-in-api branch August 26, 2021 20:32
collado-mike added a commit that referenced this pull request Sep 23, 2021
This reverts commit 1a96320.

Signed-off-by: Michael Collado <mike@datakin.com>
collado-mike added a commit that referenced this pull request Sep 24, 2021
This reverts commit 1a96320.

Signed-off-by: Michael Collado <mike@datakin.com>
collado-mike added a commit that referenced this pull request Sep 24, 2021
* Revert "API module # use OpenLineage model in OL resource (#1593)"

This reverts commit 1a96320.

Signed-off-by: Michael Collado <mike@datakin.com>

* Fix Spark openlineage package names in Spark client

Signed-off-by: Michael Collado <mike@datakin.com>

* Updated LineageEvent to be forward compatible with OpenLineage RunEvents

Signed-off-by: Michael Collado <mike@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants