-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Enable EDGE_STEPPING by default with TMC drivers #27292
🔧 Enable EDGE_STEPPING by default with TMC drivers #27292
Conversation
I disagree with doing this, default is for 'lowest' spec everything. ie in this case A4988's which do not support edge stepping. |
Good thing this feature is guarded by |
Options enabled in the configs should reflect the real configuration as closely as possible, regardless of how the conditionals might adjust them, especially for "add-on" features. So if there are no Trinamic drivers, this should be disabled. I do think it makes sense to throw a |
Anyway, the default of |
That's exactly what happens when there are no (smart) Trinamic drivers enabled since |
How many example configs need updating as they now fail to build with this new #error? Needs checking... |
My initial reluctance was due to missing that EGDE_STEPPING is in a #if HAS_TRINAMIC_CONFIG block. |
I do wonder if "we" should just go one step further. Remove edge stepping option entirely from the the Configs and just replace it in code with HAS_TRINAMIC_CONFIG tests Ie why would you ever want or need to disable it? |
I'd be fine with that as well. Just hold changes until after |
I think it's important to keep the option because it's a feature of the steppers drivers and it's nice to keep it exposed. |
Description
Enable
EDGE_STEPPING
by default. This was originally planned to be enabled by default after a test period back in 2019, but never happened (source).This is something I enable on my builds and haven't run into any issues. It's been around long enough that I think it should be enabled by default.
Requirements
Any TMC-based config.
Benefits
Better defaults for TMC-based configs.
Configurations
Any TMC-based config.