Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Add Simulator CI test #27288

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jul 18, 2024

Description

Add Simulator config for CI.

Benefits

Catch potential build issues before PRs are merged.

Configurations

Default Simulator configs

@thisiskeithb thisiskeithb added the T: Development Makefiles, PlatformIO, Python scripts, etc. label Jul 18, 2024
@thisiskeithb thisiskeithb marked this pull request as draft July 18, 2024 01:48
@thisiskeithb thisiskeithb changed the title 👷 Use default Simulator config for CI test [WIP] 👷 Use default Simulator config for CI test [WIP] Jul 18, 2024
@thisiskeithb thisiskeithb added the T: GitHub Admin GitHub actions, templates, website, etc. label Jul 18, 2024
@thisiskeithb
Copy link
Member Author

thisiskeithb commented Jul 18, 2024

h/t to @ellensp for pointing out that linux_native != simulator_linux_release.

Note

This PR originally replaced linux_native with simulator_linux_release, but I've reworked it to keep both.

@thisiskeithb thisiskeithb changed the title [WIP] 👷 Use default Simulator config for CI test [WIP] 👷 Use default Simulator config for CI test Jul 18, 2024
@thisiskeithb thisiskeithb marked this pull request as ready for review July 18, 2024 02:52
@thisiskeithb thisiskeithb changed the title 👷 Use default Simulator config for CI test 👷 Add Simulator CI test Jul 18, 2024
@thinkyhead thinkyhead merged commit 6900432 into MarlinFirmware:bugfix-2.1.x Jul 20, 2024
63 checks passed
@thisiskeithb thisiskeithb deleted the pr/use_default_sim_config branch July 20, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Development Makefiles, PlatformIO, Python scripts, etc. T: GitHub Admin GitHub actions, templates, website, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants