Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes/updates #27277

Open
wants to merge 3 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Jul 16, 2024

Description

Updates and fixes to various files.

  • Minimal fixes to spacing, comments
  • Update for better readability and proper usage
    • Changes like: #if HAS_LEVELING && HAS_ZOFFSET_ITEM) => #if ALL(HAS_LEVELING, HAS_ZOFFSET_ITEM)
  • Combine HAS_DWIN_E3V2 into HAS_DISPLAY
  • Remove redundant HAS_UI_UPDATE
  • Rearrange marlinui.h - group into similar
  • M48.cpp - when using M48 test in ProUI, make screen 'pause' ("NothingToDo")
  • Update CREALITY_V4 in pins.h to include RC board env type.

for printcounter.cpp would have to ask @thinkyhead

No real category to put these changes in.

Requirements

Benefits

Configurations

Related Issues

in marlinui.h, I am not sure whether to omit this or not. it seems as though it can be removed. so this can be reviewed:

  #if !HAS_WIRED_LCD
    static void quick_feedback(const bool=true) {}
  #endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant