Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "more" menu in LVGL, no description #21004

Merged
merged 17 commits into from
Feb 7, 2021
Merged

Fix "more" menu in LVGL, no description #21004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ae78832
Add "more" menu in LVGL interface (MKS Robin nano v.2)
Jan 30, 2021
4957a3c
Update Configuration_adv.h
Malderin Jan 30, 2021
7c3121c
Merge remote-tracking branch 'upstream/bugfix-2.0.x' into pr/20940
thinkyhead Feb 1, 2021
bf8a3e4
Custom user menus in the "marlin way". Restore configs too.
rhapsodyv Feb 1, 2021
85aed3b
now we always need more menu because of the gcode console
rhapsodyv Feb 1, 2021
f212114
more
rhapsodyv Feb 2, 2021
f69d7da
Update Configuration_adv.h
thinkyhead Feb 2, 2021
5172df0
fewer macros
thinkyhead Feb 2, 2021
97c7d62
=> HAS_USER_ITEM
thinkyhead Feb 2, 2021
272899a
not needed
thinkyhead Feb 2, 2021
f294f6c
Merge remote-tracking branch 'upstream/bugfix-2.0.x' into pr/20940
thinkyhead Feb 2, 2021
67e2e7f
Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bugfix2.0_m…
Feb 3, 2021
cc809c3
Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bugfix2.0_m…
Feb 5, 2021
bf987ea
Fix "more" menu in LVGL, no description
Feb 5, 2021
2310421
update tft_language_ru.h
Feb 5, 2021
d1293d2
update tft_language_ru.h-1
Feb 5, 2021
efe72c7
Define HAS_USER_ITEM once
thinkyhead Feb 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Marlin/src/inc/Conditionals_adv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,3 +516,10 @@
(defined(SERIAL_PORT_2) && SERIAL_PORT_2 == (N)) || \
(defined(MMU2_SERIAL_PORT) && MMU2_SERIAL_PORT == (N)) || \
(defined(LCD_SERIAL_PORT) && LCD_SERIAL_PORT == (N))

#if ENABLED(CUSTOM_USER_MENUS)
#define _HAS_1(N) (defined(USER_DESC_##N) && defined(USER_GCODE_##N))
#define HAS_USER_ITEM(V...) DO(HAS,||,V)
#else
#define HAS_USER_ITEM(N) 0
#endif
3 changes: 0 additions & 3 deletions Marlin/src/lcd/extui/lib/ftdi_eve_touch_ui/screens/custom_user_menus.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ using namespace Theme;
#define _USER_ITEM(N) .tag(_ITEM_TAG(N)).button(USER_ITEM_POS(N), _USER_DESC(N))
#define _USER_ACTION(N) case _ITEM_TAG(N): injectCommands_P(PSTR(_USER_GCODE(N))); TERN_(USER_SCRIPT_RETURN, GOTO_SCREEN(StatusScreen)); break;

#define _HAS_1(N) (defined(USER_DESC_##N) && defined(USER_GCODE_##N))
#define HAS_USER_ITEM(V...) DO(HAS,||,V)

void CustomUserMenus::onRedraw(draw_mode_t what) {
if (what & BACKGROUND) {
CommandProcessor cmd;
Expand Down
2 changes: 0 additions & 2 deletions Marlin/src/lcd/extui/lib/mks_ui/draw_more.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
extern lv_group_t * g;
static lv_obj_t * scr;

#define HAS_USER_ITEM(N) (ENABLED(CUSTOM_USER_MENUS) && defined(USER_DESC_##N) && defined(USER_GCODE_##N))

enum {
ID_GCODE = 1,
#if HAS_USER_ITEM(1)
Expand Down
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_en.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,4 +734,3 @@
#define MORE_CUSTOM4_TEXT_EN USER_DESC_4
#define MORE_CUSTOM5_TEXT_EN USER_DESC_5
#define MORE_CUSTOM6_TEXT_EN USER_DESC_6
#define MORE_CUSTOM7_TEXT_EN USER_DESC_7
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_fr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,4 +266,3 @@
#define MORE_CUSTOM4_TEXT_FR USER_DESC_4
#define MORE_CUSTOM5_TEXT_FR USER_DESC_5
#define MORE_CUSTOM6_TEXT_FR USER_DESC_6
#define MORE_CUSTOM7_TEXT_FR USER_DESC_7
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_it.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,4 +263,3 @@
#define MORE_CUSTOM4_TEXT_IT USER_DESC_4
#define MORE_CUSTOM5_TEXT_IT USER_DESC_5
#define MORE_CUSTOM6_TEXT_IT USER_DESC_6
#define MORE_CUSTOM7_TEXT_IT USER_DESC_7
6 changes: 0 additions & 6 deletions Marlin/src/lcd/extui/lib/mks_ui/tft_Language_ru.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,7 @@
#define MORE_CUSTOM4_TEXT_RU USER_DESC_4
#define MORE_CUSTOM5_TEXT_RU USER_DESC_5
#define MORE_CUSTOM6_TEXT_RU USER_DESC_6
#define MORE_CUSTOM7_TEXT_RU USER_DESC_7

//Malderin translate
//
//
#define EEPROM_STORE_TIPS_RU "Cохранить настройки в EEPROM?"
#define EEPROM_READ_TIPS_RU "читать настройки из EEPROM?"
#define EEPROM_REVERT_TIPS_RU "Cбросить настройки к значениям по умолчанию?"
Expand Down Expand Up @@ -365,5 +361,3 @@

#define ENCODER_CONF_TITLE_RU "Hастройки принтера>Hастройки энкодера"
#define ENCODER_CONF_TEXT_RU "энкодер используется?"

//end of Malderin translate
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_s_cn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,4 +501,3 @@
#define MORE_CUSTOM4_TEXT_CN USER_DESC_4
#define MORE_CUSTOM5_TEXT_CN USER_DESC_5
#define MORE_CUSTOM6_TEXT_CN USER_DESC_6
#define MORE_CUSTOM7_TEXT_CN USER_DESC_7
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_sp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,4 +272,3 @@
#define MORE_CUSTOM4_TEXT_SP USER_DESC_4
#define MORE_CUSTOM5_TEXT_SP USER_DESC_5
#define MORE_CUSTOM6_TEXT_SP USER_DESC_6
#define MORE_CUSTOM7_TEXT_SP USER_DESC_7
1 change: 0 additions & 1 deletion Marlin/src/lcd/extui/lib/mks_ui/tft_Language_t_cn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,4 +499,3 @@
#define MORE_CUSTOM4_TEXT_T_CN USER_DESC_4
#define MORE_CUSTOM5_TEXT_T_CN USER_DESC_5
#define MORE_CUSTOM6_TEXT_T_CN USER_DESC_6
#define MORE_CUSTOM7_TEXT_T_CN USER_DESC_7
160 changes: 96 additions & 64 deletions Marlin/src/lcd/extui/lib/mks_ui/tft_multi_language.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,13 +945,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_CN;
more_menu.gcode = MORE_GCODE_CN;
more_menu.entergcode = MORE_ENTER_GCODE_CN;
TERN_(USER_CMD_1_ENABLE, more_menu.custom1 = MORE_CUSTOM1_TEXT_CN);
TERN_(USER_CMD_2_ENABLE, more_menu.custom2 = MORE_CUSTOM2_TEXT_CN);
TERN_(USER_CMD_3_ENABLE, more_menu.custom3 = MORE_CUSTOM3_TEXT_CN);
TERN_(USER_CMD_4_ENABLE, more_menu.custom4 = MORE_CUSTOM4_TEXT_CN);
TERN_(USER_CMD_5_ENABLE, more_menu.custom5 = MORE_CUSTOM5_TEXT_CN);
TERN_(USER_CMD_6_ENABLE, more_menu.custom6 = MORE_CUSTOM6_TEXT_CN);
TERN_(USER_CMD_7_ENABLE, more_menu.custom7 = MORE_CUSTOM7_TEXT_CN);
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_CN;
#endif
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_CN;
#endif
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_CN;
#endif
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_CN;
#endif
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_CN;
#endif
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_CN;
#endif
// WIFI
wifi_menu.title = WIFI_TEXT;
wifi_menu.cloud = CLOUD_TEXT_CN;
Expand Down Expand Up @@ -1179,13 +1190,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_T_CN;
more_menu.gcode = MORE_GCODE_T_CN;
more_menu.entergcode = MORE_ENTER_GCODE_T_CN;
TERN_(USER_CMD_1_ENABLE, more_menu.custom1 = MORE_CUSTOM1_TEXT_T_CN);
TERN_(USER_CMD_2_ENABLE, more_menu.custom2 = MORE_CUSTOM2_TEXT_T_CN);
TERN_(USER_CMD_3_ENABLE, more_menu.custom3 = MORE_CUSTOM3_TEXT_T_CN);
TERN_(USER_CMD_4_ENABLE, more_menu.custom4 = MORE_CUSTOM4_TEXT_T_CN);
TERN_(USER_CMD_5_ENABLE, more_menu.custom5 = MORE_CUSTOM5_TEXT_T_CN);
TERN_(USER_CMD_6_ENABLE, more_menu.custom6 = MORE_CUSTOM6_TEXT_T_CN);
TERN_(USER_CMD_7_ENABLE, more_menu.custom7 = MORE_CUSTOM7_TEXT_T_CN);
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_CN;
#endif
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_CN;
#endif
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_CN;
#endif
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_CN;
#endif
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_CN;
#endif
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_CN;
#endif
// WIFI
wifi_menu.title = WIFI_TEXT;
wifi_menu.cloud = CLOUD_TEXT_T_CN;
Expand Down Expand Up @@ -1400,13 +1422,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_EN;
more_menu.gcode = MORE_GCODE_EN;
more_menu.entergcode = MORE_ENTER_GCODE_EN;
TERN_(USER_CMD_1_ENABLE, more_menu.custom1 = MORE_CUSTOM1_TEXT_EN);
TERN_(USER_CMD_2_ENABLE, more_menu.custom2 = MORE_CUSTOM2_TEXT_EN);
TERN_(USER_CMD_3_ENABLE, more_menu.custom3 = MORE_CUSTOM3_TEXT_EN);
TERN_(USER_CMD_4_ENABLE, more_menu.custom4 = MORE_CUSTOM4_TEXT_EN);
TERN_(USER_CMD_5_ENABLE, more_menu.custom5 = MORE_CUSTOM5_TEXT_EN);
TERN_(USER_CMD_6_ENABLE, more_menu.custom6 = MORE_CUSTOM6_TEXT_EN);
TERN_(USER_CMD_7_ENABLE, more_menu.custom7 = MORE_CUSTOM7_TEXT_EN);
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_EN;
#endif
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_EN;
#endif
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_EN;
#endif
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_EN;
#endif
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_EN;
#endif
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_EN;
#endif

//
filesys_menu.title = TITLE_FILESYS_EN;
Expand Down Expand Up @@ -1622,27 +1655,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_RU;
more_menu.gcode = MORE_GCODE_RU;
more_menu.entergcode = MORE_ENTER_GCODE_RU;
#if ENABLED(USER_CMD_1_ENABLE)
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_RU;
#endif
#if ENABLED(USER_CMD_2_ENABLE)
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_RU;
#endif
#if ENABLED(USER_CMD_3_ENABLE)
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_RU;
#endif
#if ENABLED(USER_CMD_4_ENABLE)
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_RU;
#endif
#if ENABLED(USER_CMD_5_ENABLE)
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_RU;
#endif
#if ENABLED(USER_CMD_6_ENABLE)
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_RU;
#endif
#if ENABLED(USER_CMD_7_ENABLE)
more_menu.custom7 = MORE_CUSTOM7_TEXT_RU;
#endif
//
filesys_menu.title = TITLE_FILESYS_RU;
filesys_menu.sd_sys = SD_CARD_TEXT_RU;
Expand Down Expand Up @@ -1954,27 +1984,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_SP;
more_menu.gcode = MORE_GCODE_SP;
more_menu.entergcode = MORE_ENTER_GCODE_SP;
#if ENABLED(USER_CMD_1_ENABLE)
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_SP;
#endif
#if ENABLED(USER_CMD_2_ENABLE)
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_SP;
#endif
#if ENABLED(USER_CMD_3_ENABLE)
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_SP;
#endif
#if ENABLED(USER_CMD_4_ENABLE)
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_SP;
#endif
#if ENABLED(USER_CMD_5_ENABLE)
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_SP;
#endif
#if ENABLED(USER_CMD_6_ENABLE)
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_SP;
#endif
#if ENABLED(USER_CMD_7_ENABLE)
more_menu.custom7 = MORE_CUSTOM7_TEXT_SP;
#endif
//
filesys_menu.title = TITLE_FILESYS_SP;
filesys_menu.sd_sys = SD_CARD_TEXT_SP;
Expand Down Expand Up @@ -2191,27 +2218,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_FR;
more_menu.gcode = MORE_GCODE_FR;
more_menu.entergcode = MORE_ENTER_GCODE_FR;
#if ENABLED(USER_CMD_1_ENABLE)
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_FR;
#endif
#if ENABLED(USER_CMD_2_ENABLE)
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_FR;
#endif
#if ENABLED(USER_CMD_3_ENABLE)
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_FR;
#endif
#if ENABLED(USER_CMD_4_ENABLE)
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_FR;
#endif
#if ENABLED(USER_CMD_5_ENABLE)
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_FR;
#endif
#if ENABLED(USER_CMD_6_ENABLE)
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_FR;
#endif
#if ENABLED(USER_CMD_7_ENABLE)
more_menu.custom7 = MORE_CUSTOM7_TEXT_FR;
#endif
//
filesys_menu.title = TITLE_FILESYS_FR;
filesys_menu.sd_sys = SD_CARD_TEXT_FR;
Expand Down Expand Up @@ -2429,27 +2453,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_IT;
more_menu.gcode = MORE_GCODE_IT;
more_menu.entergcode = MORE_ENTER_GCODE_IT;
#if ENABLED(USER_CMD_1_ENABLE)
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_IT;
#endif
#if ENABLED(USER_CMD_2_ENABLE)
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_IT;
#endif
#if ENABLED(USER_CMD_3_ENABLE)
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_IT;
#endif
#if ENABLED(USER_CMD_4_ENABLE)
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_IT;
#endif
#if ENABLED(USER_CMD_5_ENABLE)
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_IT;
#endif
#if ENABLED(USER_CMD_6_ENABLE)
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_IT;
#endif
#if ENABLED(USER_CMD_7_ENABLE)
more_menu.custom7 = MORE_CUSTOM7_TEXT_IT;
#endif
//
filesys_menu.title = TITLE_FILESYS_IT;
filesys_menu.sd_sys = SD_CARD_TEXT_IT;
Expand Down Expand Up @@ -2667,13 +2688,24 @@ void disp_language_init() {
more_menu.title = TITLE_MORE_EN;
more_menu.gcode = MORE_GCODE_EN;
more_menu.entergcode = MORE_ENTER_GCODE_EN;
TERN_(USER_CMD_1_ENABLE, more_menu.custom1 = MORE_CUSTOM1_TEXT_EN);
TERN_(USER_CMD_2_ENABLE, more_menu.custom2 = MORE_CUSTOM2_TEXT_EN);
TERN_(USER_CMD_3_ENABLE, more_menu.custom3 = MORE_CUSTOM3_TEXT_EN);
TERN_(USER_CMD_4_ENABLE, more_menu.custom4 = MORE_CUSTOM4_TEXT_EN);
TERN_(USER_CMD_5_ENABLE, more_menu.custom5 = MORE_CUSTOM5_TEXT_EN);
TERN_(USER_CMD_6_ENABLE, more_menu.custom6 = MORE_CUSTOM6_TEXT_EN);
TERN_(USER_CMD_7_ENABLE, more_menu.custom7 = MORE_CUSTOM7_TEXT_EN);
#if HAS_USER_ITEM(1)
more_menu.custom1 = MORE_CUSTOM1_TEXT_EN;
#endif
#if HAS_USER_ITEM(2)
more_menu.custom2 = MORE_CUSTOM2_TEXT_EN;
#endif
#if HAS_USER_ITEM(3)
more_menu.custom3 = MORE_CUSTOM3_TEXT_EN;
#endif
#if HAS_USER_ITEM(4)
more_menu.custom4 = MORE_CUSTOM4_TEXT_EN;
#endif
#if HAS_USER_ITEM(5)
more_menu.custom5 = MORE_CUSTOM5_TEXT_EN;
#endif
#if HAS_USER_ITEM(6)
more_menu.custom6 = MORE_CUSTOM6_TEXT_EN;
#endif
//
filesys_menu.title = TITLE_FILESYS_EN;
filesys_menu.sd_sys = SD_CARD_TEXT_EN;
Expand Down
1 change: 0 additions & 1 deletion Marlin/src/lcd/menu/menu_custom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ void _lcd_user_gcode(PGM_P const cmd) {
void menu_user() {
START_MENU();
BACK_ITEM(MSG_MAIN);
#define HAS_USER_ITEM(N) (defined(USER_DESC_##N) && defined(USER_GCODE_##N))
#define USER_ITEM(N) ACTION_ITEM_P(PSTR(USER_DESC_##N), []{ _lcd_user_gcode(PSTR(USER_GCODE_##N _DONE_SCRIPT)); });
#if HAS_USER_ITEM(1)
USER_ITEM(1);
Expand Down