Respect MANUAL_PROBE_START_Z in UBL #20160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Roxy-3D, do have any reason to NOT want UBL to respect |
|
I want to avoid merging this until I examing how it is related to #19804. It seems closely related to this, and maybe some additional adjustments are needed. |
FhlostonParadise
pushed a commit
to FhlostonParadise/Marlin
that referenced
this pull request
Nov 21, 2020
Kannix2005
pushed a commit
to Kannix2005/Marlin-1
that referenced
this pull request
Dec 7, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 8, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 11, 2021
|
Ironic that this fix for UBL, saving people their encoder wheels, for people using MBL it actually caused people to have to spin their encoder wheels more at every point! #facepalm #21239 |
This was referenced Apr 24, 2021
|
Is it this which is having the unwanted effect? #if !defined(MANUAL_PROBE_START_Z) && defined(Z_CLEARANCE_BETWEEN_PROBES)
#define MANUAL_PROBE_START_Z Z_CLEARANCE_BETWEEN_PROBES
#endifAnd so, is it only problematic when |
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PROBE_MANUALLYand UBL have a complex relationship. Enabling UBL implicitly disablesPROBE_MANUALLY, because UBL has its own manual probing mechanism.Unfortunately this also causes the
MANUAL_PROBE_START_Zto be ignored, since it wasn't originally added to UBL.This change modified UBL to use
MANUAL_PROBE_START_Z, and falls back toZ_CLEARANCE_BETWEEN_PROBESif it is available.Benefits
Allows users to reduce the amount of time they spend spinning their encoder wheels!
Configurations
The following configs are for use in the simulator. Real configs are available from the referenced issue.
Marlin.zip
Related Issues
#19795 - UBL with PROBE_MANUALLY doesn't lower to MANUAL_PROBE_START_Z and stays at Z_CLEARANCE_BETWEEN_PROBES