Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve thermistor 20-21 descriptions re: ADC Vref and INA826 PT100 supply V #19246

Commits on Sep 3, 2020

  1. Update thermistor_21.h

    Removed 5V to 3.3V table conversion.
    The conversion is leading to an erronous temperature reading, as for instance 1°C reading at room temperature.
    The 5V table provided in _ADC-counts_ is valid as long as the ADC reference voltage and the INA826 supply voltage are identical.
    The ADC is providing counts in relation to his reference voltage and the INA826 does the very same in the analog domain.
    Validated with additional PT100 measurement for 100°C and room temperature.
    Note, that the quantization error of the table in combination with rounding of the temperature reading might lead to a few degrees (seen up to 3°C) of error around the center between datapoints, e.g. 25°C, 35°C, etc.
    Quas7 authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    710abdf View commit details
    Browse the repository at this point in the history
  2. Update Configuration.h

    added temp_sensor_0 21 for integration test
    Quas7 authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    0033187 View commit details
    Browse the repository at this point in the history
  3. Update Configuration.h

    changed back for PR
    Quas7 authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8e722ac View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Update Configuration.h

    updated description for temperature probe 20 and 21
    Quas7 authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    5b7c353 View commit details
    Browse the repository at this point in the history
  2. Update thermistor_21.h

    reverted back to original code and added additional comment on intended usecase for this probe (5V INA826 supply, 3v3 ADC ref on mainboard)
    Quas7 authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    e59d9f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Update Configuration.h

    thinkyhead authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    b6c626a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Prettify

    thinkyhead committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    fea4433 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbce809 View commit details
    Browse the repository at this point in the history