-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve thermistor 20-21 descriptions re: ADC Vref and INA826 PT100 supply V #19246
Merged
thinkyhead
merged 8 commits into
MarlinFirmware:bugfix-2.0.x
from
Quas7:Quas7-patch-thermistor_21_3v3_excitation
Nov 19, 2020
Merged
Improve thermistor 20-21 descriptions re: ADC Vref and INA826 PT100 supply V #19246
thinkyhead
merged 8 commits into
MarlinFirmware:bugfix-2.0.x
from
Quas7:Quas7-patch-thermistor_21_3v3_excitation
Nov 19, 2020
Commits on Sep 3, 2020
-
Removed 5V to 3.3V table conversion. The conversion is leading to an erronous temperature reading, as for instance 1°C reading at room temperature. The 5V table provided in _ADC-counts_ is valid as long as the ADC reference voltage and the INA826 supply voltage are identical. The ADC is providing counts in relation to his reference voltage and the INA826 does the very same in the analog domain. Validated with additional PT100 measurement for 100°C and room temperature. Note, that the quantization error of the table in combination with rounding of the temperature reading might lead to a few degrees (seen up to 3°C) of error around the center between datapoints, e.g. 25°C, 35°C, etc.
Configuration menu - View commit details
-
Copy full SHA for 710abdf - Browse repository at this point
Copy the full SHA 710abdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0033187 - Browse repository at this point
Copy the full SHA 0033187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e722ac - Browse repository at this point
Copy the full SHA 8e722acView commit details
Commits on Sep 12, 2020
-
updated description for temperature probe 20 and 21
Configuration menu - View commit details
-
Copy full SHA for 5b7c353 - Browse repository at this point
Copy the full SHA 5b7c353View commit details -
reverted back to original code and added additional comment on intended usecase for this probe (5V INA826 supply, 3v3 ADC ref on mainboard)
Configuration menu - View commit details
-
Copy full SHA for e59d9f0 - Browse repository at this point
Copy the full SHA e59d9f0View commit details
Commits on Oct 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b6c626a - Browse repository at this point
Copy the full SHA b6c626aView commit details
Commits on Nov 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fea4433 - Browse repository at this point
Copy the full SHA fea4433View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbce809 - Browse repository at this point
Copy the full SHA bbce809View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.